Repository navigation
Archive projects: hidden-project helpers move into their own files - #43
Merged
Merged
Conversation
withoutArchivedProjects/isProjectArchived, the web hook and the two mobile hooks leave Upstream's projects.ts and entities.ts files, which return to Upstream's content. Behaviour is unchanged. Migration 076's guard stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…7/archive-projects # Conflicts: # CUSTOM.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ziyadakl/tokenmaxxing#116 (spec pingdotgg#107, slice 1). Behaviour unchanged.
Summary
The hidden-project helpers leave Upstream's files and live in three Fork-owned files. Upstream's call sites keep one import each.
packages/client-runtime/package.json: new export./state/archived-projects(file already edited by the Fork).Sidebar.tsx,CommandPalette.tsx,useHandleNewThread.ts,DraftHeroHeadline.tsx,ArchivedProjectsSection.tsx, mobileHomeRouteScreen.tsxandThreadNavigationSidebar.tsx. Call lines are untouched.CommandPalette.tsx:useServerConfigsback in Upstream's import order; comment shortened to one line.CUSTOM.mdrow names the new files.archived_at).Sidebar.tsx: only the import line changed. TheuseSidebarLookupscall is left for the machine-filter slice.Footprint (Upstream files the Fork edits,
MB=8657eecb28bc,--diff-filter=MD):spec107/integration)(The 11-file counts include other features' hunks in
Sidebar.tsxandCommandPalette.tsx.)git diff MB HEAD -- packages/client-runtime/src/state/projects.ts apps/web/src/state/entities.ts apps/mobile/src/state/entities.tsis empty.Evidence
projects.test.ts, 2 tests, green onspec107/integration.After: the same tests as
archivedProjects.test.ts(import line only), run withfnm exec --using=24on Node 24:archivedProjects.test.ts: 2/2076_ProjectionProjectsPinArchive.test.ts: 2/2CommandPalette.logic.test.ts, the threeCommandPalette*.browser.test.tsx,useHandleNewThread.test.ts: 55/55vp check: 0 errors (4 warnings, none in touched files).vp run knip:check: pass.tsc --noEmitin client-runtime, web and mobile: clean.Merge Danger
Door: two-way. Moves code between files; a revert restores the old layout.
Blast Radius: Sidebar, palette, new-thread picker and mobile Home/thread list (all archived-project hiding)
The next sync can clash at
Sidebar.tsxandDraftHeroHeadline.tsx, which Upstream also edited since the merge base. The machine-filter slice absorbs the remainingSidebar.tsxarchive call.🤖 Generated with Claude Code