Repository navigation
Code-review fixes for the thin-layer integration branch - #54
Merged
Merged
Conversation
…ines useSidebarEnvironmentFilter now reads Upstream's project groups itself and returns `threads` (every machine's) under Upstream's name; the sidebar narrows it with visibleThreads() at the one call that needs the filtered list. The draft-scope check moves behind environmentFilter.showsDraft(). Behaviour is unchanged (snooze wake clock input, order keys and return stamps included). Sidebar.tsx diff against the Upstream merge-base: +154 -40 -> +125 -38. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…the import alias It clashed with Upstream's hooks/useSidebarProjectGroups.ts. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
AGENTS.md: preserve existing span names. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…on store, runtimeLayer passes its layers Same layer graph: runtimeLayer hands over the layers it already builds, so no service is built twice. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Neither is Upstream text at the merge-base or a feature's; both came back with an old sync. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
CUSTOM.md's Seams column records the seams. Kept the migration 076 note: it explains code a sync would otherwise change back. Comments that explain a non-obvious line stay, without the prefix. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… still shows it Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… in-place rewrite reasons Also updates the machine filter, rewind and archive rows for the new seams. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ziyadakl/tokenmaxxing#107 (code-review fixes)
Summary
One commit per review item, no behaviour change.
Footprint (Upstream files the Fork edits, merge-base 8657eec):
Sidebar.tsxalone, beforeSidebar.tsxalone, afterNot done to the letter:
runtimeLayer.tskeeps an 8-line call, not 1-3. The layers it passes are local constants thatruntimeLayer.tsbuilds; a layer in the rewind module cannot import them without a cycle.ImportedRewindHealstays inruntimeLayer.ts(it is production-only; bundling it would add it to the test layer).sync-upstream.test.shonly covers the helpers, notcheck's step order, so it is unchanged.Evidence
After: the same 16 files, 235 tests pass.
vp check0 errors,knip:checkpass,tsc --noEmitclean in apps/web, apps/server and packages/contracts,shellcheckandsync-upstream.test.shpass.Merge Danger
Door: two-way. Code moves and comment edits; no data or setting changes.
Blast Radius: sidebar (web), rewind layer wiring (server)
Conflicts expected with any open PR touching
Sidebar.tsxorruntimeLayer.ts.🤖 Generated with Claude Code