Skip to content

Conversation

wryonik
Copy link
Collaborator

@wryonik wryonik commented Sep 26, 2025

…ore than previous one

Copy link
Member

@rutefig rutefig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for working on this. I tested the changes and wanted to share some feedback.

What I'm seeing:

When I test the updated code, the maxLength field doesn't seem to be auto-updating at all anymore. It appears to only accept manual user input and doesn't calculate based on the regex output when patterns change.

Specifically:

  • The field keeps the default length value
  • Changes to the regex pattern don't trigger any automatic maxLength updates
  • Error handling doesn't seem to be displaying as expected

I recorded a quick demo showing the behavior if that would help debug this. It looks like the auto-update functionality might not be triggering in the first place.

Would it be worth investigating why the auto-update isn't working before adding the conditional logic? I'm wondering if there might be something else going on that's preventing the feature from working as intended. Happy to help test further or provide more details!

Screen.Recording.2025-10-02.at.12.46.29.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants