You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The onchain demo pins Cash 0.4.10. Update its standalone npm dependency to published @zkp2p/cash@0.5.3 so future demo builds use the current stable SDK.
Compatibility: #70 identifies the 0.5 breaking changes as method-scoped prepareAccessPolicy and the capabilities overload. The demo does not call prepareAccessPolicy and retains the supported synchronous capabilities() call. SDK quote-identity changes are internal to Cash; the demo calls Cash estimate/order/cashout/watch/withdraw APIs. No call-site migration was required by the demo suite.
Validation at 67953a1: fresh standalone npm install, esbuild bundle, DOM-shim boot with a live EUR estimate, solc 0.8.36 compile, and local-EVM byte-exact html()/request() checks passed. The candidate is 2,372,703 bytes across 97 chunks; both view calls use approximately 11M gas and pass the existing limit checks. The example deliberately ignores its generated nested npm lockfile under its packed-artifact policy.
Visual verification
Independent gauntlet-design-review PASS at 67953a1836f30f1192f83aaa15070e7c26643580: fresh desktop/mobile, light/dark, empty/estimate and missing-wallet evidence. Built and opened out/PeerCash.html in real Chrome at 1440×1000 and 390×844; mobile has no horizontal overflow and the console has no errors. Wallet transaction flows were not exercised. UI diff audit: zero findings.
Original implementation evidence at the same head: inspected real Chrome at 1440×1000 and 390×844, populated Revolut/EUR and entered 100 USDC; the candidate displayed 86.05 EUR at 0.8605 EUR/USDC, with readable controls and no horizontal overflow on mobile. Logged-out coverage only; no wallet transaction was submitted. Repository CI run 34509656798 passed the full bun run ci gate. This PR updates source for future builds; it does not deploy or replace the immutable production contract.
codex review --base origin/main exited 0 with no actionable findings. Code-taste T11/T13: the demo retains supported Cash call sites; the one-line published dependency pin needs no compatibility adapter or implementation cleanup. PR copy scan is clean.
Fresh standalone npm install, bundle, DOM boot with live EUR estimate, solc compile, and local-EVM contract tests passed. Output: 2,372,703 bytes / 97 chunks; html() and request() are byte-exact and each uses approximately 11M gas within the test caps. Full repository CI passed at this head.
Independent gauntlet-design-review: PASS at the exact head. Opened the freshly built out/PeerCash.html in real Chrome, inspected 1440×1000 and 390×844, light/dark themes, empty and populated estimate states, input focus, and the missing-wallet error. Revolut/EUR with 100 USDC rendered 86.05 EUR at 0.8605 EUR/USDC; mobile document width equals viewport width (390px); no browser console errors. The unchanged layout keeps the amount, estimate and wallet action readable without new decorative elements. UI diff audit: zero findings. Captures below are from this review.
Wallet transaction flows were not exercised; this source-only example dependency update does not deploy the immutable production contract.
Repair passes: 0. No unresolved reviews or newly arrived human requests. Live main is unprotected and the applicable branch-rules list is empty. No release or deployment is part of this PR.
Post-merge cascade complete: source fdfb28fe2dd9b9a47a343ec49e25df52e25f986d verified on default branch main; merge-commit CI passed.
Only examples/onchain-demo/package.json changed. No mapped release environments or release branches apply; deployment skipped. This ships source for future demo builds, without replacing the immutable deployed contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The onchain demo pins Cash 0.4.10. Update its standalone npm dependency to published
@zkp2p/cash@0.5.3so future demo builds use the current stable SDK.Compatibility: #70 identifies the 0.5 breaking changes as method-scoped
prepareAccessPolicyand thecapabilitiesoverload. The demo does not callprepareAccessPolicyand retains the supported synchronouscapabilities()call. SDK quote-identity changes are internal to Cash; the demo calls Cash estimate/order/cashout/watch/withdraw APIs. No call-site migration was required by the demo suite.Validation at
67953a1: fresh standalonenpm install, esbuild bundle, DOM-shim boot with a live EUR estimate, solc 0.8.36 compile, and local-EVM byte-exacthtml()/request()checks passed. The candidate is 2,372,703 bytes across 97 chunks; both view calls use approximately 11M gas and pass the existing limit checks. The example deliberately ignores its generated nested npm lockfile under its packed-artifact policy.Visual verification
Independent gauntlet-design-review PASS at
67953a1836f30f1192f83aaa15070e7c26643580: fresh desktop/mobile, light/dark, empty/estimate and missing-wallet evidence. Built and openedout/PeerCash.htmlin real Chrome at 1440×1000 and 390×844; mobile has no horizontal overflow and the console has no errors. Wallet transaction flows were not exercised. UI diff audit: zero findings.Original implementation evidence at the same head: inspected real Chrome at 1440×1000 and 390×844, populated Revolut/EUR and entered 100 USDC; the candidate displayed 86.05 EUR at 0.8605 EUR/USDC, with readable controls and no horizontal overflow on mobile. Logged-out coverage only; no wallet transaction was submitted. Repository CI run 34509656798 passed the full
bun run cigate. This PR updates source for future builds; it does not deploy or replace the immutable production contract.