Fix build instructions #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use the copy & paste feature from GH's rendered README.md this $ sign is also copied and needs to be removed when pasted into a shell. Removing the $ makes it possible to paste the command w/o manual edit. Signed-off-by: Sven Strittmatter <[email protected]>
Signed-off-by: Sven Strittmatter <[email protected]>
The documented way to build seems to be outdated:
```
go get github.com/zmap/zgrab2
go: go.mod file not found in current directory or any parent directory.
'go get' is no longer supported outside a module.
To build and install a command, use 'go install' with a version,
like 'go install example.com/cmd@latest'
For more information, see https://golang.org/doc/go-get-install-deprecation
or run 'go help get' or 'go help install'.
```
What works for me: Clone the repo and simply run `make` inside the repo
to build the binary.
Signed-off-by: Sven Strittmatter <[email protected]>
dadrian
approved these changes
Jul 11, 2023
|
Hi, what's up? |
|
Sorry for the delay. Thanks for helping us with the documentation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documented way with
go getgives an error message:I'm not very experienced with go. Worked works for me: Clone repo and run
make.