Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.go #421

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Update config.go #421

merged 1 commit into from
Apr 12, 2024

Conversation

L4puta
Copy link
Contributor

@L4puta L4puta commented Apr 12, 2024

fix /metrics 404 error

prometheus metrics return 404 Not Found

How to Test

go version go1.22.2 linux/amd64
Linux 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

before
curl localhost:10000/metrics
404 page not found

after
curl localhost:10000/metrics

# HELP go_gc_duration_seconds A summary of the pause duration of garbage collection cycles.
# TYPE go_gc_duration_seconds summary
go_gc_duration_seconds{quantile="0"} 3.2542e-05
go_gc_duration_seconds{quantile="0.25"} 6.0905e-05
go_gc_duration_seconds{quantile="0.5"} 8.1575e-05
go_gc_duration_seconds{quantile="0.75"} 0.000107555
go_gc_duration_seconds{quantile="1"} 0.000347025
go_gc_duration_seconds_sum 0.011626545
go_gc_duration_seconds_count 131
# HELP go_goroutines Number of goroutines that currently exist.
# TYPE go_goroutines gauge
go_goroutines 4...

fix /metrics 404 error
Copy link
Contributor

@phillip-stephens phillip-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix @L4puta!!

@phillip-stephens phillip-stephens merged commit 9dce324 into zmap:master Apr 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants