Add support for custom DNS server #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developStorm
changed the title
phillip-stephens
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Minor changes, really looks good overall. Appreciate your commenting of variables/functions and everything is quite clean and readable! This will be a great feature for people doing large scale scans.
Did you validate that using this flag sends DNS queries to the specified server with Wireshark or something? Could you update the PR description with your testing to show that it fixes the issue?
Co-authored-by: Phillip Stephens <[email protected]>
Co-authored-by: Phillip Stephens <[email protected]>
Co-authored-by: Phillip Stephens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #419
validated that the flag works with Wireshark: