-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Protocol: AMQP 0.9.1 #426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case we add separate support for amqp v1.0.0 in future
developStorm
force-pushed
the
feat/amqp-support
branch
from
May 15, 2024 07:45
8ce8908
to
10e4da6
Compare
developStorm
force-pushed
the
feat/amqp-support
branch
3 times, most recently
from
May 22, 2024 22:10
a3ebe08
to
44bbfee
Compare
developStorm
requested review from
phillip-stephens
and removed request for
phillip-stephens
June 2, 2024 21:45
phillip-stephens
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for scanning AMQP(S) 0.9.1 hosts.
The protocol supports following special flags:
zgrab2/modules/amqp/scanner.go
Lines 13 to 23 in e4ea1b2
Tested locally against a RabbitMQ server, with and without valid credentials:
resolves #214.