Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Multi-platform Docker Builds and Integration Test #428

Merged
merged 21 commits into from
May 21, 2024

Conversation

developStorm
Copy link
Member

@developStorm developStorm commented May 20, 2024

This PR introduces GitHub Actions for multi-platform Docker image building and integration test execution. It also includes patches for integration tests, schemas, and scanner modules to address issues identified by the integration tests. Relevant documentations are also reviewed and updated.

.py file changes are mostly caused by applying formatter, with an exception of the mongodb schema file.

@developStorm developStorm self-assigned this May 20, 2024
@developStorm developStorm marked this pull request as ready for review May 20, 2024 07:27
@developStorm developStorm force-pushed the build/docker-and-integration-test branch from 67d90b7 to 257e51c Compare May 20, 2024 07:29
@developStorm developStorm force-pushed the build/docker-and-integration-test branch from d076e5d to 6e49325 Compare May 20, 2024 21:18
Copy link
Contributor

@phillip-stephens phillip-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpick, overall looks great and will really help us in being confident in approving PR's!

zgrab2_schemas/README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
modules/pop3/scanner.go Outdated Show resolved Hide resolved
Copy link
Contributor

@phillip-stephens phillip-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@developStorm developStorm merged commit 8513c35 into master May 21, 2024
3 checks passed
@developStorm developStorm deleted the build/docker-and-integration-test branch May 21, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants