-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Multi-platform Docker Builds and Integration Test #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use more reliable way to determine project root
according to rfc1939, merely +OK is a valid response in the AUTHORIZATION state
developStorm
force-pushed
the
build/docker-and-integration-test
branch
from
May 20, 2024 07:29
67d90b7
to
257e51c
Compare
developStorm
force-pushed
the
build/docker-and-integration-test
branch
from
May 20, 2024 21:18
d076e5d
to
6e49325
Compare
phillip-stephens
requested changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nitpick, overall looks great and will really help us in being confident in approving PR's!
phillip-stephens
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces GitHub Actions for multi-platform Docker image building and integration test execution. It also includes patches for integration tests, schemas, and scanner modules to address issues identified by the integration tests. Relevant documentations are also reviewed and updated.
.py
file changes are mostly caused by applying formatter, with an exception of the mongodb schema file.