Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code/test to work with latest Python 3.12 and add CI #68

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

phillip-stephens
Copy link
Contributor

@phillip-stephens phillip-stephens commented Jan 17, 2025

Wanted to remove the dependency of using Python 2 in ZGrab, so updating zschema to be more current.

  • Switch from the deprecated nose to pytest, swapping out equivalent functions so it compiles
  • Added GH CI to run pytest on all PR's
  • Follow current best-practices for using SetupTools, eschewing setup.py for a pyproject.toml file
  • Ran black . to lint

Testing

Tested with python 3.12, ran pytest and all tests pass with no warnings

~/zschema on  master! ⌚ 16:09:14
$ pytest
================================== test session starts ==================================
platform darwin -- Python 3.12.3, pytest-8.3.2, pluggy-1.5.0
rootdir: /Users/phillip/zschema
configfile: pyproject.toml
plugins: xdist-3.6.1
collected 48 items

zschema/test_zschema.py ................................................          [100%]

================================== 48 passed in 0.05s ===================================

@phillip-stephens phillip-stephens merged commit bd9c53b into master Jan 23, 2025
1 check passed
@phillip-stephens phillip-stephens deleted the phillip/update branch January 23, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants