Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kscan): fix unused variable warning in kssb #2317

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ReFil
Copy link
Contributor

@ReFil ReFil commented May 31, 2024

If using sideband kscan for tasks other than soft off (i.e. with CONFIG_PM_DEVICE disabled) the compiler throws an unused variable warning. Moving the variable inside the #if IS_ENABLED(CONFIG_PM_DEVICE) fixes this warning

If using sideband kscan for tasks other than soft off (i.e. with CONFIG_PM_DEVICE disabled) the compiler throws an unused variable warning. Moving inside the #if IS_ENABLED(CONFIG_PM_DEVICE) fixes this warning
@ReFil ReFil requested a review from a team as a code owner May 31, 2024 09:13
Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this explains what #2255 was (partially) attempting to deal with. Seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants