Update veracode-pipeline-scan.yml #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added documentation steps to header Migrated from KeyVault to pipeline variables Added condition to download Veracode policy file - would error out previously if using built-in policy Combined JS & TS steps to be single step, to mirror the format of veracode-policy-scan.yml file Added artifact publish step to publish veracode scan file results.json as a build artifact
zoekdestep
reviewed
Jul 11, 2022
There was a problem hiding this comment.
Hey, thanks so much for the commit! Largest part looks great - but there are certain use cases (especially enterprise environments) where we'd not want to use pipeline variables. I'd like to keep that in as an example on how to connect to Azure KeyVault. Feel free to make an additional file that uses pipeline variables instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation steps to header
Migrated from KeyVault to pipeline variables
Added condition to download Veracode policy file - would error out previously if using built-in policy
Combined JS & TS steps to be single step, to mirror the format of veracode-policy-scan.yml file
Added artifact publish step to publish veracode scan file results.json as a build artifact