Skip to content

merge into main needs main checked out - #20

Merged
github-actions[bot] merged 2 commits into
mainfrom
improve/F-20-merge-ff
Oct 30, 2026
Merged

github-actions[bot] merged 2 commits into
mainfrom
improve/F-20-merge-ff

Conversation

@zolotarev

Copy link
Copy Markdown
Owner

Friction — merge into main needs main checked out

Seen ×0 in 0 task(s) of one project.

merge/deliver --into main refuse unless main is open in a copy; the main copy could not switch (vendored .dpcli on main vs submodule on the feature branch), a fast-forward needs no checkout

Change

  • VERSION 31, CHANGELOG
  • merge --into a branch open in no copy: fast-forward without a checkout

Sent by dpcli contribute. Anonymized: no project names, paths or quotes.

@zolotarev zolotarev added the feedback Friction reported from real use label Oct 30, 2026
@github-actions

Copy link
Copy Markdown

VERDICT: accept

  • Real friction (main copy cannot switch to main); a fast-forward via update-ref with the old value is safe against lost concurrent updates and refuses diverged targets with a clear hint.
  • Test covers both the fast-forward and the diverged refusal; VERSION 31 and the CHANGELOG line are present, with no new dependencies.
  • Nit: the PR body says "Seen ×0 in 0 task(s)", and no open feedback issue matches; the evidence is thin, so link the real occurrence next time.
  • Nit: --push on this path runs git push with cwd=None (the current copy). That works, but there is no test for it.
  • Nit: this path always fast-forwards, while the checked-out path always makes a merge commit (ff=False). The difference is acceptable here, but it is worth a word in the docs.

@github-actions
github-actions Bot merged commit 3b1fc21 into main Oct 30, 2026
3 checks passed
@github-actions
github-actions Bot deleted the improve/F-20-merge-ff branch October 30, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback Friction reported from real use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant