[zolotarev]

Friction — write guard rejects heredoc and in-place shell edits, costing a round

Seen ×28 in 26 task(s) of one project.

executors repeatedly lose a round rewriting the edit via Read+Edit

Change

• write guard rejects heredoc and in-place shell edits, costing a round

Sent by dpcli contribute. Anonymized: no project names, paths or quotes.

[github-actions]

VERDICT: accept

• Real friction (×28 in 26 tasks, feedback label); both fixes are small and scoped to hooks/bash_guard.py. Tests cover the ignored-target pass and the still-blocked src/ case. VERSION 37 and the CHANGELOG line are present, with no project data.
• Nit, hooks/bash_guard.py writes: a heredoc line passes if any quoted path on it is git-ignored, even when the write goes elsewhere, e.g. Path('src/a.py').write_text(open('build/x').read()). Such a line is rare, so this is acceptable, but matching the path inside the open(...)/write_* call would be stricter.
• Nit, scratch(): if git is missing, subprocess.run raises FileNotFoundError and the hook crashes. Wrap it in try/except OSError and return False. Outside a repo, check-ignore returns 128, which correctly means "not ignored".
• I did not run the tests locally; this verdict comes from reading the diff.