Skip to content

plan: a missing section named like a contracts file gives no hint - #47

Merged
github-actions[bot] merged 2 commits into
mainfrom
improve/F-7-plan-a-missing-section-named-like-a-cont
Nov 11, 2026
Merged

github-actions[bot] merged 2 commits into
mainfrom
improve/F-7-plan-a-missing-section-named-like-a-cont

Conversation

@zolotarev

Copy link
Copy Markdown
Owner

Friction — plan: a missing section named like a contracts file gives no hint

Seen ×9 in 3 task(s) of one project.

Cards named another module's contracts file as a section; the error gave no way to the file.

Change

  • plan: a missing section named like a contracts file gives no hint

Sent by dpcli contribute. Anonymized: no project names, paths or quotes.

@zolotarev zolotarev added the feedback Friction reported from real use label Nov 11, 2026
@github-actions

Copy link
Copy Markdown

VERDICT: accept

  • Real friction (×9 reports, cards naming another module's contracts file as a section); the fix is a 4-line hint in lib/dpcli/commands/plan.py:48, with no new dependency or prompt growth.
  • Correct: --contracts is kept in the table-of-contents hint. The file hint is shown only when <dir>/<name>.md exists and differs from the current file. The check is read-only and rel() handles paths.
  • Tested: test_missing_section_named_like_a_contracts_file_points_to_it covers both hints. VERSION is bumped to 48 with a CHANGELOG line, and the text is English and anonymized.
  • Nit: CHANGELOG says "6 reports" but the PR body says ×9. Align them if convenient.

@github-actions

Copy link
Copy Markdown

Review accepted, but the test workflow is failure: fix and push again.

@github-actions

Copy link
Copy Markdown

VERDICT: accept

  • Solves a real friction (9 reports): a section named like a sibling contracts file now yields a pointer plan <rel path>, and the table-of-contents hint keeps --contracts.
  • Correct: path.parent / name.md works for both module and file targets; other != path and is_file() guard the hint; read-only, no journal changes.
  • Tested: test_missing_section_named_like_a_contracts_file_points_to_it covers both the --contracts hint and the file pointer. I could not run the suite in the review sandbox.
  • Process: VERSION 47→48 and CHANGELOG entry present, English, anonymized; no budget files touched.
  • Nit: the plan_edit not-found error (plan.py:73) lacks the same hint; add it only if reports show up.

@github-actions github-actions Bot removed the rework label Nov 11, 2026
@github-actions
github-actions Bot merged commit d112e41 into main Nov 11, 2026
3 checks passed
@github-actions
github-actions Bot deleted the improve/F-7-plan-a-missing-section-named-like-a-cont branch November 11, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback Friction reported from real use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant