Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reach 100% coverage. #67

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Reach 100% coverage. #67

merged 1 commit into from
Oct 11, 2018

Conversation

jamadden
Copy link
Member

Simplify and remove a lot of unused/unneeded functions in _compat.py

Fix transaction.manager.run to handle mixed byte and text strings in doc.

Simplify and remove a lot of unused/unneeded functions in _compat.py

Fix ``transaction.manager.run`` to handle mixed byte and text strings
in ``doc``.
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamadden jamadden merged commit 0d29b05 into master Oct 11, 2018
@jamadden jamadden deleted the issue66 branch October 11, 2018 15:17
@jamadden
Copy link
Member Author

Thanks!

Should we release now (@icemac) or should we wait for something to happen with #64 / #63 ?

@icemac
Copy link
Member

icemac commented Oct 19, 2018

@jamadden As a bird in the hand is worth two in the bush, a release now would be fine.

@jamadden
Copy link
Member Author

2.3.0 has been released to PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants