Fix resource warnings in tests. #19
Conversation
There was a problem hiding this comment.
I'm in favor of fixing resource warnings! The changes in fileresult.txt look fine, but I'm concerned that the changes to FileView (returning a string instead of an open file) are pretty fundamental. In WSGI, it's the caller's responsibility to close() the returned body content. Maybe this is masking an issue elsewhere?
| file = open(fn, 'rb') | ||
| return file | ||
| with open(fn, 'rb') as file: | ||
| return file.read() |
There was a problem hiding this comment.
I'm not sure this is testing what it was testing before. Because the line above writes a constant to the file, this whole function could be simplified to just return b'Hello\nWorld!\n'
There was a problem hiding this comment.
You are right, it now does something completely different. I'll dig into the code to find out where the file should be closed as it seems to be a feature to return a file handle from a view.
| @@ -37,8 +37,8 @@ def __call__(self): | |||
| fn = tempfile.mktemp() | |||
There was a problem hiding this comment.
Bad test is not cleaning after itself! And creates completely anonymous temporary files.
No description provided.