-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optionally assignable labels to variables #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #66 and #16 by allowing users to assign labels to variables in the table, and allowing other variables to reference labels of other variables in their address formula.
More details:
$n
token is used to give labels a different number. Conventionally it should be at the end of the variable name, e.gFoo_$n
will createFoo_0
,Foo_1
, ...ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-_$
label("...")
function is added when evaluating address formulas via DDMathParser, which does a lookup to see which variable in the table (if any) has the specified label and returns its current addressdebug.updateVariable(label, addressStrOrNum)
anddebug.variableAddress(label)
are added for updating the address formula of a labeled variable and for retrieving the address of a label respectively. Updating a variable currently contributes to creating undo/redo actions in the variable controller even via scripting.-> Label Foo
), unless that variable is also labeled in which case only its label is shown. Annotations of variables in the table are updated when labeled variables are added, removed, their labels are altered, or when a variable address that uses a label is altered.A -> A
, orA -> B
andB -> A
. [edit]: we have some prevention now for cycles in 8aaa9f0