Note HTML: Replace bidi control chars with HTML #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to fix zotero/zotero#3552. I don't have access to desktop Office and the problem doesn't occur in Word Online, so this is just a best guess.
We could use
<bdi>, but<span>seems safer; very old editors (<bdi>was implemented in browsers around 2012) might handle an unknown tag badly.All editors I tried - Word Online, Google Docs, TextEdit, Zotero's note editor - strip the
<span>s when pasting, so they're harmless but also maybe useless. I think I like the idea of keeping them because they do serve a purpose, but we could also just remove them fully.