Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allows to obtain certificates from multiple sources #3914

Merged
merged 9 commits into from
Nov 28, 2024

Conversation

pj892031
Copy link
Contributor

Description

This PR allows to define of multiple services (gateways) to allow them to forward client certificates. It requires to obtain certificates used for forwarding from multiple URLs.

The change renames configuration properties (with supporting the original one) - see the plural and the processing of a list of URLs.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Signed-off-by: Pavel Jareš <[email protected]>
@github-actions github-actions bot added the Sensitive Sensitive change that requires peer review label Nov 26, 2024
@pj892031 pj892031 marked this pull request as ready for review November 27, 2024 20:10
Copy link

sonarcloud bot commented Nov 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
70.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@pj892031 pj892031 merged commit 2e028cb into v3.x.x Nov 28, 2024
26 of 27 checks passed
@pj892031 pj892031 deleted the reboot/multiple-urls-for-cert-forwarding branch November 28, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sensitive Sensitive change that requires peer review size/L
Projects
Development

Successfully merging this pull request may close these issues.

2 participants