Skip to content

Commit

Permalink
first round of interface changes
Browse files Browse the repository at this point in the history
Signed-off-by: zFernand0 <[email protected]>
  • Loading branch information
zFernand0 committed Mar 5, 2024
1 parent 8016f6e commit 2bd0cdc
Show file tree
Hide file tree
Showing 26 changed files with 461 additions and 349 deletions.
68 changes: 0 additions & 68 deletions .eslintrc.js

This file was deleted.

50 changes: 50 additions & 0 deletions .eslintrc.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
env:
es2021: true
node: true
extends:
- eslint:recommended
- plugin:@typescript-eslint/recommended
ignorePatterns:
- "**/*.js"
- "**/*.d.ts"
overrides:
- extends:
- "plugin:jest/recommended"
files:
- "**/__tests__/**/*.ts"
rules:
jest/expect-expect: ["warn", { "assertFunctionNames": ["expect*", "**.*expect*"] }]
jest/no-conditional-expect: off
jest/no-standalone-expect: off
jest/no-try-expect: off
unused-imports/no-unused-vars: off
"@typescript-eslint/no-magic-numbers": off
parser: "@typescript-eslint/parser"
parserOptions:
ecmaVersion: 12
sourceType: module
plugins:
- "@typescript-eslint"
- jest
- unused-imports
rules:
max-len: ["warn", 150]
no-console: error
no-multiple-empty-lines: warn
no-trailing-spaces: warn
"@typescript-eslint/ban-types": off
"@typescript-eslint/comma-dangle": ["warn", "only-multiline"]
"@typescript-eslint/explicit-module-boundary-types": off
"@typescript-eslint/indent": ["warn", 4]
"@typescript-eslint/no-explicit-any": warn
"@typescript-eslint/no-inferrable-types": off
"@typescript-eslint/no-magic-numbers": ["warn", {
"ignore": [-1, 0, 1, 2],
"ignoreDefaultValues": true,
"ignoreReadonlyClassProperties": true
}]
"@typescript-eslint/no-unused-vars": off
"@typescript-eslint/no-var-requires": off
"@typescript-eslint/semi": warn
"unused-imports/no-unused-imports": warn
"unused-imports/no-unused-vars": ["warn", { "args": "none" }]
45 changes: 45 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,51 @@ All notable changes to the z/OS FTP Plug-in for Zowe CLI will be documented in t

- Major: Zowe V3 release

- **Enhancements**:
- The following properties, interfaces, and/or functions were added:
- `IListJobOption.jobName`
- `IListJobOption.jobId`
- `ITransferMode`
- For a full list of transfer modes, see [TransferMode by zos-node-accessor](https://github.com/IBM/zos-node-accessor/blob/faf55873f37cc40e927f1b1c19f697de8cf08b95/src/zosAccessor.ts#L67)
- **Breaking**:
- Removed the following constants, interfaces, and other values:
- `IGetSpoolFileOption.jobName`
- Added proper typing to the parameters of the following functions:
- `CoreUtils.addLowerCaseKeysToObject`
- Return type changed: `any --> IDatasetEntry`
- `CreateDataset.create`
- `DataSetUtils.listDataSets`
- `FTPConfig.connectFromArguments`
- `FTPConfig.createConfigFromArguments`
- `JobUtils.getSpoolFileContent`
- Return type changed: `Promise<Buffer> --> Promise<string>`
- `JobUtils.getSpoolFiles`
- `JobUtils.submitJob`
- `JobUtils.submitJobFromDataset`
- `JobUtils.findJobByID`
- `UssUtils.listFiles`
- Return type changed: `Promise<any[]> --> Promise<IDatasetEntry[]>`
- `UssUtils.makeDirectory`
- `UssUtils.renameFile`
- `UssUtils.deleteFile`
- `UssUtils.downloadFile`
- `UssUtils.uploadFile`
- `UssUtils.deleteDirectory`
- The properties in the interfaces below have changed:
- `IDownloadFileOption.transferType?: string` to `IDownloadFileOption.transferType?: ITransferMode`
- `IUploadFileOption.transferType?: string` to `IUploadFileOption.transferType?: ITransferMode`
- `ISpoolFile.id: string` to `ISpoolFile.id: number`
- `ISpoolFile.stepname: string` to `ISpoolFile.stepName: string`
- `ISpoolFile.procstep: string` to `ISpoolFile.procStep: string`
- `ISpoolFile.ddname: string` to `ISpoolFile.ddName: string`
- `ISpoolFile.ddname: string` to `ISpoolFile.ddName: string`
- `IJobStatus.jobname: string` to `IJobStatus.jobName: string`
- `IJobStatus.jobid: string` to `IJobStatus.jobId: string`
- `IJob.jobname: string` to `IJob.jobName: string`
- `IJob.jobid: string` to `IJob.jobId: string`
- `IGetSpoolFileOption.fileId: string` to `IGetSpoolFileOption.fileId: number`
-

## `2.1.8`

- BugFix: Upload dataset using Buffer, stead of string. [2533](https://github.com/zowe/vscode-extension-for-zowe/issues/2533)
Expand Down
182 changes: 163 additions & 19 deletions npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@zowe/imperative": ">=8.0.0-next.0 <8.0.0"
},
"dependencies": {
"zos-node-accessor": "1.0.16"
"zos-node-accessor": "2.0.9"
},
"devDependencies": {
"@types/jest": "^29.5.12",
Expand Down
Loading

0 comments on commit 2bd0cdc

Please sign in to comment.