Update dependencies and prepare script #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
gejohnston
reviewed
Oct 29, 2024
| }, | ||
| "imperative": { | ||
| "configurationModule": "lib/pluginDef.js" | ||
| }, | ||
| "dependencies": { | ||
| "@zowe/core-for-zowe-sdk": "^7.23.2", | ||
| "@zowe/zosmf-for-zowe-sdk": "^7.23.2" | ||
| "@zowe/core-for-zowe-sdk": "^7.29.2", |
There was a problem hiding this comment.
Should our sample remain a V2 sample, or should it be a V3 sample?
There was a problem hiding this comment.
I don't mind moving things into a zowe-v2-lts branch after this PR is merged 🙏
t1m0thyj
reviewed
Oct 29, 2024
__tests__/__integration__/cli/list/cli.list.profile-args.integration.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
|
waiting for a new version from: |
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
traeok
approved these changes
Oct 30, 2024
| # If not a merge commit, require commit to be signed off | ||
| if [ ! -e .git/MERGE_MSG ] && ! grep -q "^Signed-off-by: " "$1"; then | ||
| if [ ! -e $(git rev-parse --git-dir)/MERGE_MSG ] && ! grep -q "^Signed-off-by: " "$1"; then |
There was a problem hiding this comment.
That's a cool method for getting the git directory 😋
gejohnston
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
How to Test
Review Checklist
I certify that I have:
Additional Comments