refactor: check if maxLength exists before comparison

Signed-off-by: Trae Yelovich <[email protected]>
zowe · Jan 22, 2025 · 6dff86a · 6dff86a
1 parent 2adf7d3
commit 6dff86a
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/packages/zosfiles/src/methods/list/List.ts b/packages/zosfiles/src/methods/list/List.ts
@@ -430,11 +430,18 @@ export class List {
         ImperativeExpect.toNotBeEqual(patterns.length, 0, ZosFilesMessages.missingPatterns.message);
         const zosmfResponses: IZosmfListResponse[] = [];
 
+        const maxLength = options.maxLength;
+
+        let totalCount = 0;
         // Get names of all data sets
         for (const pattern of patterns) {
+            if (maxLength && totalCount >= options.maxLength) {
+                break;
+            }
             let response: any;
             try {
-                response = await List.dataSet(session, pattern, { attributes: true, maxLength: options.maxLength, start: options.start });
+                response = await List.dataSet(session, pattern,
+                    { attributes: true, maxLength: maxLength ? maxLength - totalCount : undefined, start: options.start });
             } catch (err) {
                 if (!(err instanceof ImperativeError && err.errorCode?.toString().startsWith("5"))) {
                     throw err;
@@ -472,6 +479,9 @@ export class List {
                     await asyncPool(maxConcurrentRequests, response.apiResponse.items, createListPromise);
                 }
             }
+            if (response.success && response.apiResponse?.items?.length > 0) {
+                totalCount += response.apiResponse.items.length;
+            }
             zosmfResponses.push(...response.apiResponse.items);
         }