zowe · ATorrise · Jan 30, 2024 · Nov 13, 2023 · Nov 14, 2023 · Nov 14, 2023
diff --git a/__tests__/__packages__/cli-test-utils/src/TestUtils.ts b/__tests__/__packages__/cli-test-utils/src/TestUtils.ts
@@ -62,15 +62,6 @@ export function runCliScript(scriptPath: string, testEnvironment: ITestEnvironme
     }
 }
 
-/**
- * Check if stderr output is empty for profiles command. Ignores any message
- * about profiles being deprecated.
- * @deprecated Use `stripProfileDeprecationMessages`
- */
-export function isStderrEmptyForProfilesCommand(output: Buffer): boolean {
-    return stripProfileDeprecationMessages(output).length === 0;
-}
-
 /**
  * Strip v1 profile deprecation messages from stderr output.
  */

diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json
diff --git a/packages/cli/CHANGELOG.md b/packages/cli/CHANGELOG.md
@@ -2,6 +2,25 @@
 
 All notable changes to the Zowe CLI package will be documented in this file.
 
+## Recent Changes
+
+LTS Breaking: Removed the following previously deprecated items: [#1981](https://github.com/zowe/zowe-cli/pull/1981)
+  - Moved the many constants from `zowe-cli/packages/cli/src/Constants.ts` to `zowe-cli/packages/core/src/constants/Core.constants.ts`
+  - Removing `ZosFilesCreateExtraOptions.showAttributes` without replacement
+  - Moved all constants from `zowe-cli/packages/cli/src/zostso/constants/ZosTso.constants.ts` to  `@zowe/zos-tso-for-zowe-sdk`
+  - Removed `isStderrEmptyForProfilesCommand` use `stripProfileDeprecationMessages` from `zowe-cli/__tests__/__packages__/cli-test-utils/src/TestUtils.ts` instead
+  - Removed  `allDataSetsArchived`, `datasetsDownloadedSuccessfully`, `noDataSetsMatchingPatternRemain` and `onlyEmptyPartitionedDataSets` from    ZosFiles.messages.ts
+  - Removed `getSpoolDownloadFile` use `getSpoolDownloadFilePath` instead
+  - Removed constants from ZosmfSession
+    - ZOSMF_OPTION_HOST_PROFILE use ZOSMF_OPTION_HOST instead
+    - ZOSMF_OPTION_USER_PROFILE use ZOSMF_OPTION_USER instead
+    - ZOSMF_OPTION_PASSWORD_PROFILE use ZOSMF_OPTION_PASSWORD instead
+  - Removed constants from SshSession.ts
+    - SSH_OPTION_USER_PROFILE use SSH_OPTION_USER
+    - SSH_OPTION_HOST_PROFILE use SSH_OPTION_HOST
+  - Removed zosmfProfile from `ZosFilesBase.handler.ts`
+  - Removed statCmdFlag as an export from Shell.ts
+
 ## `8.0.0-next.202401262128`
 
 - Enhancement: Adding `--binary` and `--encoding` options to `zosfiles edit`

diff --git a/...tests__/zosfiles/__integration__/edit/uss/__snapshots__/edit.uss.integration.test.ts.snap b/...tests__/zosfiles/__integration__/edit/uss/__snapshots__/edit.uss.integration.test.ts.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`View USS file should display the help 1`] = `
+exports[`Edit USS file should display the help 1`] = `
 "================Z/OS FILES EDIT USS FILE HELP===============
 
  COMMAND NAME
@@ -161,7 +161,7 @@ exports[`View USS file should display the help 1`] = `
 "
 `;
 
-exports[`View USS file should display the help in json format 1`] = `
+exports[`Edit USS file should display the help in json format 1`] = `
 "================Z/OS FILES EDIT USS FILE HELP===============
 {
   \\"success\\": true,

diff --git a/packages/cli/__tests__/zosfiles/__integration__/edit/uss/edit.uss.integration.test.ts b/packages/cli/__tests__/zosfiles/__integration__/edit/uss/edit.uss.integration.test.ts
@@ -16,7 +16,7 @@ import { ITestPropertiesSchema } from "../../../../../../../__tests__/__src__/pr
 
 let TEST_ENVIRONMENT: ITestEnvironment<ITestPropertiesSchema>;
 
-describe("View USS file", () => {
+describe("Edit USS file", () => {
 
     beforeAll(async () => {
         TEST_ENVIRONMENT = await TestEnvironment.setUp({

diff --git a/packages/cli/__tests__/zosfiles/__unit__/ZosFilesBase.handler.unit.test.ts b/packages/cli/__tests__/zosfiles/__unit__/ZosFilesBase.handler.unit.test.ts
@@ -9,7 +9,7 @@
 *
 */
 
-import { AbstractSession, IHandlerParameters, IProfile, Session } from "@zowe/imperative";
+import { AbstractSession, IHandlerParameters, Session } from "@zowe/imperative";
 import { IZosFilesResponse } from "@zowe/zos-files-for-zowe-sdk";
 import { ZosFilesBaseHandler } from "../../../src/zosfiles/ZosFilesBase.handler";
 
@@ -21,8 +21,7 @@ describe("ZosFilesBaseHandler", () => {
 
         public async processWithSession(
             commandParameters: IHandlerParameters,
-            session: AbstractSession,
-            zosmfProfile: IProfile
+            session: AbstractSession
         ): Promise<IZosFilesResponse> {
             return this.returnResponse;
         }

diff --git a/..._/zosfiles/__unit__/create/binaryPds/__snapshots__/BinaryPDS.definition.unit.test.ts.snap b/..._/zosfiles/__unit__/create/binaryPds/__snapshots__/BinaryPDS.definition.unit.test.ts.snap
@@ -101,15 +101,6 @@ Array [
     "name": "secondary-space",
     "type": "number",
   },
-  Object {
-    "aliases": Array [
-      "pa",
-    ],
-    "description": "Show the full allocation attributes",
-    "hidden": true,
-    "name": "show-attributes",
-    "type": "boolean",
-  },
   Object {
     "aliases": Array [
       "sz",

diff --git a/...i/__tests__/zosfiles/__unit__/create/cPds/__snapshots__/CPDS.definition.unit.test.ts.snap b/...i/__tests__/zosfiles/__unit__/create/cPds/__snapshots__/CPDS.definition.unit.test.ts.snap
@@ -101,15 +101,6 @@ Array [
     "name": "secondary-space",
     "type": "number",
   },
-  Object {
-    "aliases": Array [
-      "pa",
-    ],
-    "description": "Show the full allocation attributes",
-    "hidden": true,
-    "name": "show-attributes",
-    "type": "boolean",
-  },
   Object {
     "aliases": Array [
       "sz",

diff --git a/...zosfiles/__unit__/create/classicPds/__snapshots__/ClassicPDS.definition.unit.test.ts.snap b/...zosfiles/__unit__/create/classicPds/__snapshots__/ClassicPDS.definition.unit.test.ts.snap
@@ -101,15 +101,6 @@ Array [
     "name": "secondary-space",
     "type": "number",
   },
-  Object {
-    "aliases": Array [
-      "pa",
-    ],
-    "description": "Show the full allocation attributes",
-    "hidden": true,
-    "name": "show-attributes",
-    "type": "boolean",
-  },
   Object {
     "aliases": Array [
       "sz",

diff --git a/...s/cli/__tests__/zosfiles/__unit__/create/ds/__snapshots__/ds.definition.unit.test.ts.snap b/...s/cli/__tests__/zosfiles/__unit__/create/ds/__snapshots__/ds.definition.unit.test.ts.snap
@@ -104,15 +104,6 @@ Array [
     "name": "secondary-space",
     "type": "number",
   },
-  Object {
-    "aliases": Array [
-      "pa",
-    ],
-    "description": "Show the full allocation attributes",
-    "hidden": true,
-    "name": "show-attributes",
-    "type": "boolean",
-  },
   Object {
     "aliases": Array [
       "sz",

diff --git a/...cli/__tests__/zosfiles/__unit__/create/pds/__snapshots__/Pds.definition.unit.test.ts.snap b/...cli/__tests__/zosfiles/__unit__/create/pds/__snapshots__/Pds.definition.unit.test.ts.snap
@@ -110,15 +110,6 @@ Array [
     "name": "secondary-space",
     "type": "number",
   },
-  Object {
-    "aliases": Array [
-      "pa",
-    ],
-    "description": "Show the full allocation attributes",
-    "hidden": true,
-    "name": "show-attributes",
-    "type": "boolean",
-  },
   Object {
     "aliases": Array [
       "sz",

diff --git a/...s/cli/__tests__/zosfiles/__unit__/create/ps/__snapshots__/Ps.definition.unit.test.ts.snap b/...s/cli/__tests__/zosfiles/__unit__/create/ps/__snapshots__/Ps.definition.unit.test.ts.snap
@@ -91,15 +91,6 @@ Array [
     "name": "secondary-space",
     "type": "number",
   },
-  Object {
-    "aliases": Array [
-      "pa",
-    ],
-    "description": "Show the full allocation attributes",
-    "hidden": true,
-    "name": "show-attributes",
-    "type": "boolean",
-  },
   Object {
     "aliases": Array [
       "sz",

diff --git a/...i/__tests__/zosfiles/__unit__/create/vsam/__snapshots__/Vsam.definition.unit.test.ts.snap b/...i/__tests__/zosfiles/__unit__/create/vsam/__snapshots__/Vsam.definition.unit.test.ts.snap
@@ -80,15 +80,6 @@ Array [
     "name": "secondary-space",
     "type": "number",
   },
-  Object {
-    "aliases": Array [
-      "pa",
-    ],
-    "description": "Show the full allocation attributes",
-    "hidden": true,
-    "name": "show-attributes",
-    "type": "boolean",
-  },
   Object {
     "aliases": Array [
       "sz",

diff --git a/packages/cli/__tests__/zosfiles/__unit__/download/dsm/DataSetMatching.handler.unit.test.ts b/packages/cli/__tests__/zosfiles/__unit__/download/dsm/DataSetMatching.handler.unit.test.ts
@@ -35,7 +35,6 @@ const fakeDownloadOptions: IDownloadOptions = {
     binary: undefined,
     directory: undefined,
     encoding: undefined,
-    excludePatterns: undefined,
     extension: undefined,
     extensionMap: undefined,
     failFast: undefined,

diff --git a/packages/cli/__tests__/zosuss/__system__/issue/cli.issue.ssh.system.test.ts b/packages/cli/__tests__/zosuss/__system__/issue/cli.issue.ssh.system.test.ts
@@ -16,7 +16,7 @@ import { TestEnvironment } from "../../../../../../__tests__/__src__/environment
 import { ITestPropertiesSchema } from "../../../../../../__tests__/__src__/properties/ITestPropertiesSchema";
 import { ZosFilesConstants } from "@zowe/zos-files-for-zowe-sdk";
 import { ZosmfRestClient } from "@zowe/core-for-zowe-sdk";
-import { startCmdFlag } from "@zowe/zos-uss-for-zowe-sdk";
+import { Shell } from "@zowe/zos-uss-for-zowe-sdk";
 
 
 // Test environment will be populated in the "beforeAll"
@@ -35,7 +35,7 @@ let keyPassphrase: string;
 function checkResponse(response: any, expectStatus: number) {
     expect(response.stderr.toString()).toBe("");
     expect(response.status).toBe(expectStatus);
-    expect(response.stdout.toString()).not.toMatch(startCmdFlag);
+    expect(response.stdout.toString()).not.toMatch(Shell.startCmdFlag);
 }
 
 function generateRandomString(j: number) {