Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flattening Imperative and separating out tests #2020

Closed
wants to merge 180 commits into from
Closed

Flattening Imperative and separating out tests #2020

wants to merge 180 commits into from

Conversation

ATorrise
Copy link
Contributor

@ATorrise ATorrise commented Jan 17, 2024

What It Does

  • Flattens zowe-cli/packages/imperative
    • takes tests out of src
    • removes redundant file structure ie src/packageName/src
    • an effort towards standardizing imperative's structure to that of other packages' structure
  • Allows 1 ts-configuration file to apply over entire zowe-cli/packages/imperative/__tests__
  • Is part of the clean-up effort for v3

Review Checklist
I certify that I have:

Additional Comments

  • Unsure about how to incorporate changelog
  • fixing up imperative package inspired by previous tsconfig-related PR

awharn and others added 30 commits November 28, 2023 15:29
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Deprecate old getDataSet in v2 LTS, move to zosfiles SDK
Signed-off-by: Timothy Johnson <[email protected]>
…o allow for `forceUpdate`s

Signed-off-by: zFernand0 <[email protected]>
…neratedCommands

Remove call to CliProfileManager.initialize from Imperative.init.
Remove BasicProfileManager.initialize.
Remove AbstractProfileManager.createProfileTypeDirectory

Signed-off-by: Gene Johnston <[email protected]>
Nice catch! Thank you, @traeok

Co-authored-by: Trae Yelovich <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
feat(imperative): Enhanced `ProfileInfo.updateProperty`
Signed-off-by: Gene Johnston <[email protected]>
chore: Add Linux dev. pre-requisites to README
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (841d840) 91.03% compared to head (e5b1edb) 76.27%.
Report is 248 commits behind head on next.

Files Patch % Lines
.../cli/src/workflows/create/Create.common.handler.ts 0.00% 5 Missing ⚠️
...rkflows/start/workflowStep/WorkflowStep.handler.ts 0.00% 2 Missing ⚠️
...veWorkflowDetails/ActiveWorkflowDetails.handler.ts 0.00% 1 Missing ⚠️
...ws/list/activeWorkflows/ActiveWorkflows.handler.ts 50.00% 1 Missing ⚠️
...ist/archivedWorkflows/ArchivedWorkflows.handler.ts 50.00% 1 Missing ⚠️
...owDefinition/RetrieveWorkflowDefinition.handler.ts 50.00% 1 Missing ⚠️
...rkflows/start/workflowFull/WorkflowFull.handler.ts 0.00% 1 Missing ⚠️
packages/core/src/rest/ZosmfRestClient.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             next    #2020       +/-   ##
===========================================
- Coverage   91.03%   76.27%   -14.76%     
===========================================
  Files         635      635               
  Lines       18610    18629       +19     
  Branches     3859     3866        +7     
===========================================
- Hits        16941    14209     -2732     
- Misses       1668     4418     +2750     
- Partials        1        2        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Amber Torrise <[email protected]>
@zFernand0 zFernand0 self-requested a review January 18, 2024 14:03
awharn and others added 19 commits January 18, 2024 14:44
Signed-off-by: Andrew W. Harn <[email protected]>
Update Jest Configuration to run more tests in GHA
Remove the 'zowe profiles' command group

The macos 20.x test failure was due to an intermittent pipeline error in the early 'install dependencies' step. It is not indicative of a problem with the Zowe code.
This reverts commit 80d26e1.

Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
…ive/config/cmd- and fixing files

Signed-off-by: Amber Torrise <[email protected]>
import { setupConfigToLoad } from "../../../../../../__tests__/src/TestUtil";
import { SessConstants } from "../../../../../src/rest";
import { setupConfigToLoad } from "../../../../../__tests__/src/TestUtil";
import { IHandlerFormatOutputApi } from "../../../../../src";

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused import IHandlerFormatOutputApi.
@ATorrise ATorrise closed this Jan 31, 2024
@ATorrise ATorrise deleted the orgImp branch February 13, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants