Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing profile versioning return value from commands about environment #2053

Merged
merged 15 commits into from
Feb 23, 2024

Conversation

ATorrise
Copy link
Contributor

What It Does
Part of the modernization effort in preparation for v3. Given v1 profiles will no longer be supported, their consideration in certain command logic is no longer necessary.

How to Test

  1. Append your command with --show-inputs-only.
  2. Test zowe config report-env.
    Ensure neither command returns anything related to differentiating your environment between TeamConfig of v1

Review Checklist
I certify that I have:

Additional Comments
If there are any other commands the team can think of that return information about environment for user information that have special logic for v1, the removal of that logic could be appended to this PR.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 88.79%. Comparing base (3fcffd1) to head (ff4fbd4).

❗ Current head ff4fbd4 differs from pull request most recent head ae06f7f. Consider uploading reports for the commit ae06f7f to get more accurate results

Files Patch % Lines
...ackages/imperative/src/cmd/src/CommandProcessor.ts 40.00% 6 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           rm-profile-handlers    #2053      +/-   ##
=======================================================
- Coverage                90.92%   88.79%   -2.13%     
=======================================================
  Files                      616      616              
  Lines                    17165    17153      -12     
  Branches                  3616     3551      -65     
=======================================================
- Hits                     15607    15231     -376     
- Misses                    1557     1921     +364     
  Partials                     1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ATorrise ATorrise linked an issue Feb 15, 2024 that may be closed by this pull request
@zFernand0
Copy link
Member

zFernand0 commented Feb 15, 2024

Smart to have based your branch off of the rm-profile-handlers branch 🥳
The only downside is that you may run into issues coming from that WIP branch 😋

Changes LGTM! 😋

just gotta address a few failing tests 😅

@zFernand0 zFernand0 marked this pull request as draft February 15, 2024 21:11
@gejohnston
Copy link
Member

Thanks for going beyond just changing the text that is displayed. The removal of V1 logic in report-env is above and beyond the original issue, but a very worthwhile change.

I confirmed that your branch has the same bug fix as the original branch from which you created your branch. So you were right, your test errors are the result of some specific changes in your branch.

Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
@ATorrise ATorrise marked this pull request as ready for review February 20, 2024 19:26
Copy link

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, thanks @ATorrise! Left a few comments about how we handle secure inputs.

zFernand0
zFernand0 previously approved these changes Feb 21, 2024
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@ATorrise ATorrise requested a review from t1m0thyj February 21, 2024 17:18
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the secure values test to handle team config 👍 Left a few comments.

@zFernand0 zFernand0 dismissed their stale review February 22, 2024 22:06

waiting for test to be added back 😋

@ATorrise
Copy link
Contributor Author

@gejohnston Are these failing tests acceptable or should I do something about them?

@gejohnston
Copy link
Member

Are these failing tests acceptable or should I do something about them?

@ATorrise I think that we should merge this branch into rm-profile-handlers. I think that the error will not exist in the rm-profile-handlers branch. Even if there is a problem, it will be easier to fix in that branch.

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if we want to fix the tests in another branch after merge 🙂

Left a comment about why the test may be failing

@@ -2329,6 +2334,7 @@ describe("Command Processor", () => {
envVariablePrefix: ENV_VAR_PREFIX,
definition: SAMPLE_COMMAND_REAL_HANDLER_WITH_OPT,
helpGenerator: FAKE_HELP_GENERATOR,
profileManagerFactory: FAKE_PROFILE_MANAGER_FACTORY,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may need to remove this line now to fix the failing unit tests?

@gejohnston gejohnston merged commit d7813e2 into rm-profile-handlers Feb 23, 2024
11 checks passed
@gejohnston gejohnston deleted the show-inputs-only branch February 23, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zowe --show-inputs-only always reporting zowe version as v1
4 participants