-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies next #2059
Update dependencies next #2059
Conversation
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2059 +/- ##
==========================================
+ Coverage 91.04% 91.05% +0.01%
==========================================
Files 638 638
Lines 18610 18610
Branches 3857 3856 -1
==========================================
+ Hits 16943 16946 +3
+ Misses 1666 1663 -3
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
@@ -45,7 +45,7 @@ | |||
"prepack": "node ../../scripts/prepareLicenses.js" | |||
}, | |||
"dependencies": { | |||
"comment-json": "^4.1.1", | |||
"comment-json": "~4.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting...
Have you had bad experiences with updating to 4.2.x
and above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it changes the return type to CommentJSONType which breaks a lot of things. :(
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - had a question about one of the ESLint comments. Thanks @awharn!
packages/imperative/src/security/src/abstract/AbstractCredentialManager.ts
Show resolved
Hide resolved
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Perform a number of updates to dependencies for technical currency
How to Test
Review Checklist
I certify that I have:
Additional Comments