Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies next #2059

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Update dependencies next #2059

merged 5 commits into from
Feb 21, 2024

Conversation

awharn
Copy link
Member

@awharn awharn commented Feb 21, 2024

What It Does

Perform a number of updates to dependencies for technical currency

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (43922b1) 91.04% compared to head (cb32e31) 91.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2059      +/-   ##
==========================================
+ Coverage   91.04%   91.05%   +0.01%     
==========================================
  Files         638      638              
  Lines       18610    18610              
  Branches     3857     3856       -1     
==========================================
+ Hits        16943    16946       +3     
+ Misses       1666     1663       -3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@@ -45,7 +45,7 @@
"prepack": "node ../../scripts/prepareLicenses.js"
},
"dependencies": {
"comment-json": "^4.1.1",
"comment-json": "~4.1.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting...
Have you had bad experiences with updating to 4.2.x and above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it changes the return type to CommentJSONType which breaks a lot of things. :(

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - had a question about one of the ESLint comments. Thanks @awharn!

@zFernand0 zFernand0 merged commit 77e5141 into next Feb 21, 2024
20 of 21 checks passed
@zFernand0 zFernand0 deleted the update-dependencies-next branch February 21, 2024 18:48
Copy link

Release succeeded for the next branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants