Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies next phase 2 #2061

Merged
merged 21 commits into from
Feb 23, 2024
Merged

Conversation

awharn
Copy link
Member

@awharn awharn commented Feb 21, 2024

What It Does

Updates the remaining packages (except yargs and typescript) to their latest versions
Replaces lerna with lerna-lite for a lightweight Lerna experience
Removes get-stream for a native node function
Removes unneeded dependencies:

  • @types/find-up
  • shebang-regex
  • syncpack
  • tsc-watch

Increases node engine required version to >=16.7.0

The following packages could not be fully upgraded:
chalk - ESM
diff2html - Using specialized version
find-up - ESM
markdown-it - Breaks HTML links
string-width - ESM
strip-ansi - ESM
ts-node - Breaks imports of @zowe/secrets-for-zowe-sdk
wrap-ansi - ESM

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
@t1m0thyj t1m0thyj requested a review from anaxceron February 21, 2024 23:11
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 91.08%. Comparing base (735b0c9) to head (97b5658).
Report is 2 commits behind head on next.

Files Patch % Lines
packages/imperative/src/utilities/src/CliUtils.ts 66.66% 4 Missing ⚠️
...es/cli/src/zosjobs/submit/Submit.shared.handler.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2061   +/-   ##
=======================================
  Coverage   91.08%   91.08%           
=======================================
  Files         638      638           
  Lines       18824    18825    +1     
  Branches     3809     3809           
=======================================
+ Hits        17146    17147    +1     
  Misses       1677     1677           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of notes.

Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn awharn force-pushed the update-dependencies-next-phase-2 branch from 02e9b9a to 08ebe15 Compare February 22, 2024 20:49
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn awharn mentioned this pull request Feb 23, 2024
4 tasks
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn!

Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Copy link
Member Author

awharn commented Feb 23, 2024

I don't think fixing the typedoc requires a changelog entry. 😅

@awharn awharn merged commit e2a25ee into next Feb 23, 2024
44 of 45 checks passed
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
78.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@awharn awharn deleted the update-dependencies-next-phase-2 branch February 23, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants