Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS tgz containing extra GNUSparseFile.0 directory #2126

Merged
merged 5 commits into from
May 3, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented May 1, 2024

What It Does

Fixes regression of #1311 (broke in v7.11.2)

How to Test

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (65d4aa9) to head (b2ed039).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2126   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files         636      636           
  Lines       19035    19035           
  Branches     4008     4009    +1     
=======================================
  Hits        17346    17346           
  Misses       1688     1688           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me! 😋

Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a note about the changelog item.

Signed-off-by: Timothy Johnson <[email protected]>
@t1m0thyj t1m0thyj requested a review from anaxceron May 2, 2024 16:56
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks timoteo!

Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix looks good to me, thanks Timothy!

@t1m0thyj t1m0thyj merged commit 113e5eb into master May 3, 2024
22 checks passed
@t1m0thyj t1m0thyj deleted the fix/macos-daemon-tgz branch May 3, 2024 13:21
@t1m0thyj t1m0thyj added the release-patch Indicates a patch to existing code has been applied label May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Release succeeded for the master branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

@awharn awharn mentioned this pull request May 15, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants