Remove remaining references to V1 profiles pt 2 #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <[email protected]>
t1m0thyj
requested review from
gejohnston,
zFernand0,
awharn,
traeok,
jace-roell and
ATorrise
Signed-off-by: Timothy Johnson <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2249 +/- ##
==========================================
- Coverage 91.30% 91.26% -0.05%
==========================================
Files 632 628 -4
Lines 18147 17821 -326
Branches 3849 3820 -29
==========================================
- Hits 16570 16264 -306
+ Misses 1576 1556 -20
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
awharn
approved these changes
Aug 29, 2024
|
|
The uncovered lines are in TestConstants, which is only used for tests. Not sure why a test file is being marked as not covered by tests. |
zFernand0
approved these changes
Aug 30, 2024
Signed-off-by: Timothy Johnson <[email protected]>
t1m0thyj
force-pushed
the
fix/remove-v1-profiles
branch
from
b06f7c5 to
937889e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
For the most part this PR just removes stuff that was deprecated in #2239 or previously.
It also updates unit tests for
CliUtilsmodule to callgetOptValuesForConfig, and makes a few changes to that method which were required for full backwards compatibility.How to Test
Review Checklist
I certify that I have:
Additional Comments