Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use ubuntu-22.04 for secrets-sdk and zowe-cli workflows #2306

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Oct 14, 2024

What It Does

libsecret was removed from the Ubuntu 24 runner image. Downgrading to ubuntu-22.04 will allow us to import Secrets SDK and use it in tests without error.

@traeok traeok changed the title ci: use ubuntu-22.04 for secrets-sdk and zowe-cli workflows ci: use ubuntu-22.04 for secrets-sdk and zowe-cli workflows Oct 14, 2024
@traeok traeok marked this pull request as ready for review October 14, 2024 13:48
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.08%. Comparing base (ad015e0) to head (3ddd441).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2306   +/-   ##
=======================================
  Coverage   91.08%   91.08%           
=======================================
  Files         628      628           
  Lines       17896    17896           
  Branches     3848     3847    -1     
=======================================
  Hits        16300    16300           
  Misses       1595     1595           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

hoping we can figure out how to get back to the ubuntu-latest soon 🙏

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

@traeok traeok merged commit b68a70b into master Oct 14, 2024
47 checks passed
@traeok traeok deleted the ci/linux/fix-libsecret branch October 14, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants