fix encoding not being used on upload file to uss#2334
Conversation
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2334 +/- ##
==========================================
+ Coverage 91.12% 91.13% +0.01%
==========================================
Files 636 636
Lines 18007 18002 -5
Branches 3758 3863 +105
==========================================
- Hits 16408 16406 -2
+ Misses 1598 1595 -3
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
awharn
left a comment
There was a problem hiding this comment.
Shouldn't this have a bugfix changelog?
zFernand0
left a comment
There was a problem hiding this comment.
changes LGTM! 😋
have a few requested changes though 😋
|
I believe it's safe to ignore this sonarcloud coverage warnings. This is one of the rare occassions where they are not in sync, and I think we said we go with codecov one 😋 Sonarcloud
Codecov
|
Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com>
There was a problem hiding this comment.
LGTM, thanks @jace-roell!
When testing this PR I noticed the command to upload a directory doesn't show a progress bar, so filed a separate issue for it: #2344
Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com>
|


What It Does
fix encoding not being used on upload file to uss, system test fix
Review Checklist
I certify that I have: