Skip to content

fix encoding not being used on upload file to uss#2334

Merged
t1m0thyj merged 12 commits intomasterfrom
encoding-ftu-fix
Nov 4, 2024
Merged

fix encoding not being used on upload file to uss#2334
t1m0thyj merged 12 commits intomasterfrom
encoding-ftu-fix

Conversation

@jace-roell
Copy link
Copy Markdown
Contributor

What It Does
fix encoding not being used on upload file to uss, system test fix

Review Checklist
I certify that I have:

Signed-off-by: jace-roell <jace.roell@hotmail.com>
@jace-roell jace-roell changed the title [v3] fix encoding not being used on upload file to uss, system test fix [v3] fix encoding not being used on upload file to uss Oct 30, 2024
@jace-roell jace-roell changed the title [v3] fix encoding not being used on upload file to uss fix encoding not being used on upload file to uss Oct 30, 2024
@jace-roell jace-roell marked this pull request as draft October 30, 2024 18:08
Comment thread packages/zosfiles/src/methods/upload/Upload.ts Outdated
Signed-off-by: jace-roell <jace.roell@hotmail.com>
@jace-roell jace-roell requested a review from awharn October 30, 2024 18:24
@jace-roell jace-roell marked this pull request as ready for review October 30, 2024 18:24
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.13%. Comparing base (952c1ac) to head (1d9a7bd).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
packages/zosfiles/src/methods/upload/Upload.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2334      +/-   ##
==========================================
+ Coverage   91.12%   91.13%   +0.01%     
==========================================
  Files         636      636              
  Lines       18007    18002       -5     
  Branches     3758     3863     +105     
==========================================
- Hits        16408    16406       -2     
+ Misses       1598     1595       -3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread packages/zosfiles/src/methods/upload/Upload.ts Outdated
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Comment thread packages/zosfiles/src/methods/upload/Upload.ts Fixed
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
@jace-roell jace-roell marked this pull request as draft October 31, 2024 15:43
Signed-off-by: jace-roell <jace.roell@hotmail.com>
@jace-roell jace-roell requested a review from traeok October 31, 2024 18:38
@jace-roell jace-roell marked this pull request as ready for review October 31, 2024 18:38
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Copy link
Copy Markdown
Member

@awharn awharn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this have a bugfix changelog?

Copy link
Copy Markdown
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM! 😋
have a few requested changes though 😋

Comment thread packages/cli/src/zosfiles/upload/ftu/FileToUSS.handler.ts
Comment thread packages/zosfiles/src/methods/upload/Upload.ts Outdated
Comment thread packages/zosfiles/src/methods/upload/Upload.ts
@zFernand0
Copy link
Copy Markdown
Member

I believe it's safe to ignore this sonarcloud coverage warnings. This is one of the rare occassions where they are not in sync, and I think we said we go with codecov one 😋

Sonarcloud

Quality Gate Failed Quality Gate failed

Failed conditions 66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Codecov

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.14%. Comparing base (715242f) to head (af735f2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packages/zosfiles/src/methods/upload/Upload.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

jace-roell and others added 2 commits November 1, 2024 11:31
Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Copy link
Copy Markdown
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jace-roell!

When testing this PR I noticed the command to upload a directory doesn't show a progress bar, so filed a separate issue for it: #2344

Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@t1m0thyj t1m0thyj merged commit 23b05f1 into master Nov 4, 2024
@t1m0thyj t1m0thyj deleted the encoding-ftu-fix branch November 4, 2024 14:53
@t1m0thyj t1m0thyj added the release-current Indicates that there is no new functionality being delivered label Nov 4, 2024
@t1m0thyj t1m0thyj removed this from Zowe CLI Squad Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-current Indicates that there is no new functionality being delivered

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants