-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth order spike #2372
base: master
Are you sure you want to change the base?
Auth order spike #2372
Conversation
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2372 +/- ##
========================================
Coverage 91.27% 91.27%
========================================
Files 638 638
Lines 18141 18141
Branches 3914 3805 -109
========================================
Hits 16559 16559
Misses 1581 1581
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that the tests are failing, but I approve of the design document, hence my approval. Very comprehensive and covered any questions that I had throughout my review. Thanks Gene for writing this proposal.
Given the context of where the changes would need to be made and following up on our previous in-person discussion, we may be able to leverage the Config
class for these new functions. ProfileInfo
has access to the loaded, merged config instance, so we can leverage this in Zowe Explorer to get access to the authentication order for a given profile. It seems that ImperativeConfig.instance.config
might also be valid at the time a CLI command is run, so it could be used to access the authentication order as part of building the session.
Signed-off-by: Gene Johnston <[email protected]>
Signed-off-by: Gene Johnston <[email protected]>
Quality Gate passedIssues Measures |
What It Does
This PR contains a design document proposing how Zowe clients could enable users to specify their own preferred order of authentication.
Certainly, the proposed approach should be the primary focus of reviews. Several secondary items to consider are:
I purposely chose to place this design document in the Zowe GitHub repository.
This is a draft PR.
It will be easier to read the document from the repo than from the file diffs.
https://github.com/zowe/zowe-cli/blob/auth-order-spike/docs/Design_for_selecting_auth_type.md
Alternatively, if you download the file and view it in the VSCode "Markdown Preview" window, you get a little splash of color which make some things easier to identify.
Review Checklist
I certify that I have: