Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 sys test fix port #2373

Merged
merged 13 commits into from
Nov 25, 2024
Merged

V2 sys test fix port #2373

merged 13 commits into from
Nov 25, 2024

Conversation

jace-roell
Copy link
Contributor

@jace-roell jace-roell commented Nov 20, 2024

What It Does
port system test fixes from V3.

GitHub issue# and link:

#2336
#2353
#2354

Review Checklist
I certify that I have:

Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.25%. Comparing base (fca0224) to head (bf7edfb).
Report is 29 commits behind head on zowe-v2-lts.

Files with missing lines Patch % Lines
...perative/src/rest/src/client/AbstractRestClient.ts 71.42% 2 Missing ⚠️
...ackages/imperative/src/operations/src/Operation.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           zowe-v2-lts    #2373   +/-   ##
============================================
  Coverage        91.25%   91.25%           
============================================
  Files              638      638           
  Lines            19150    19162   +12     
  Branches          3944     3947    +3     
============================================
+ Hits             17475    17486   +11     
- Misses            1674     1675    +1     
  Partials             1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jace-roell jace-roell marked this pull request as ready for review November 25, 2024 14:34
Copy link
Member

@awharn awharn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works great! Thanks for backporting these, @jace-roell!

Signed-off-by: jace-roell <[email protected]>
jest.config.js Outdated Show resolved Hide resolved
Signed-off-by: jace-roell <[email protected]>
@jace-roell jace-roell requested a review from t1m0thyj November 25, 2024 17:51
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Jace for porting this over!

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

From a little earlier this morning!

Test Suites: 138 passed, 138 total
Tests:       3 skipped, 1201 passed, 1204 total
Snapshots:   100 passed, 100 total
Time:        2814.569 s

@zFernand0 zFernand0 merged commit 08e02ce into zowe-v2-lts Nov 25, 2024
13 of 14 checks passed
@zFernand0 zFernand0 deleted the v2-sys-test-fix-port branch November 25, 2024 21:41
@zFernand0 zFernand0 added the release-current Indicates that there is no new functionality being delivered label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-current Indicates that there is no new functionality being delivered
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

6 participants