-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample scripts #341
Sample scripts #341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @olamidepeterojo,
Please add the missing signoffs
Also, there may be more places that need to be updated (aside from the example mentioned in the issue)
As another example, files.delete_data_set -> Dataset.delete
😋
My apologies for missing out my signoffs again...Will do accordingly |
0de23c9
to
03288f0
Compare
Signed-off-by: Olamide Ojo <[email protected]>
03288f0
to
016670e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
=======================================
Coverage 89.10% 89.10%
=======================================
Files 65 65
Lines 3258 3258
=======================================
Hits 2903 2903
Misses 355 355
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Third-Party DCO Remediation Commit for Olamide Ojo <[email protected]> On behalf of Olamide Ojo <[email protected]>, I, Fernando Rijo Cedeno <[email protected]>, hereby add my Signed-off-by to this commit: 5408903 Signed-off-by: Fernando Rijo Cedeno <[email protected]> Signed-off-by: Fernando Rijo Cedeno <[email protected]>
f86a641
to
ed0514d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @olamidepeterojo,
I believe that as part of this issue, we not only want to update test files... but also update the sample scripts provided to users in the various readme files.
Here is a list of what we could review for accuracy:
- Available commands in: https://github.com/zowe/zowe-client-python-sdk/blob/main/README.md#available-options
- Scripts in: https://github.com/zowe/zowe-client-python-sdk/tree/main/samples
- Individual readme files in:
src/*/README.md
…into sample-scripts
Signed-off-by: Olamide Ojo <[email protected]>
…owe-client-python-sdk into sample-scripts Signed-off-by: Olamide Ojo <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @olamidepeterojo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
thanks for the contribution
What It Does
Updated sample scripts in readme to stop using deprecated methods
Fixes #336
How to Test
Review Checklist
I certify that I have:
Additional Comments