-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor HTTP Server Authentication code #169
base: v1.x/staging
Are you sure you want to change the base?
Conversation
d036319
to
d14649d
Compare
d14649d
to
c9cd1b1
Compare
Signed-off-by: Leonty Chudinov <[email protected]>
c9cd1b1
to
e24fd2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, the changes look good to me. I would still other people to take a look, especially since this is related to security. @rocketjared, @1000TurquoisePogs, what do you think?
Signed-off-by: Leonty Chudinov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at it and it seems good to me as well.
This is a follow up for #162.
request->authenticated
field always actual.SERVICE_AUTH_FLAG_OPTIONAL
is set. The intent is to distinguishcookies). In this case: