Created functionality for creating dataset members #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanfilteau1995
requested changes
Aug 1, 2019
Signed-off-by: Charlie Caron <[email protected]>
chcaron01
force-pushed
the
create-member
branch
from
cbbbe61
to
d9d5f84
Compare
jordanfilteau1995
approved these changes
Aug 2, 2019
|
DO NOT MERGE until merge conflicts are resolved in zowe/zss#62 |
ifakhrutdinov
requested changes
Aug 8, 2019
| Volser volser = {0}; | ||
|
|
||
| DatasetName dsn = {0}; | ||
| memcpy(dsn.value, datasetName, DATASET_NAME_LEN); |
There was a problem hiding this comment.
A dataset name is not necessarily DATASET_NAME_LEN bytes. This may 0C4. And for DSCB it probably needs to be space padded.
| char dscb[INDEXED_DSCB] = {0}; | ||
| int bufferSize = sizeof(dscb); | ||
| if (getDSCB(datasetPath, dscb, bufferSize) != 0) { | ||
| respondWithJsonError(response, "Error decoding dataset", 400, "Bad Request"); |
There was a problem hiding this comment.
Can you return from here early and not have a huge else?
| respondWithJsonError(response, "Error decoding dataset", 400, "Bad Request"); | ||
| } | ||
| else { | ||
| if (!isPartionedDataset(dscb)) { |
There was a problem hiding this comment.
Same here. Just check and return in case of an error.
| } | ||
| } | ||
|
|
||
| void newDatasetMember(HttpResponse* response, char* datasetPath, char* memberName) { |
There was a problem hiding this comment.
Why not follow the same convention as the rest of the function, i.e. require a full path? Please also do all the validation and checks (whether the dataset is on an offline volume), that's done in https://github.com/zowe/zowe-common-c/blob/staging/c/datasetjson.c#L832
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Charlie Caron [email protected]