Skip to content

Prepare 3.1.0 release #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 28, 2025
Merged

Prepare 3.1.0 release #3398

merged 7 commits into from
Jan 28, 2025

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Jan 14, 2025

Proposed changes

Prepare 3.1.0 release

Release Notes

Milestone: 3.1.0

Changelog: n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

@JillieBeanSim JillieBeanSim added the no-changelog Add to PR's that don't require a CHANGELOG update label Jan 14, 2025
@JillieBeanSim JillieBeanSim added this to the v3.1.0 milestone Jan 14, 2025
@JillieBeanSim JillieBeanSim self-assigned this Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.19%. Comparing base (d7c1554) to head (ea08136).
Report is 1 commits behind head on release/3.1.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/3.1    #3398      +/-   ##
===============================================
- Coverage        93.19%   93.19%   -0.01%     
===============================================
  Files              120      120              
  Lines            12499    12510      +11     
  Branches          2841     2842       +1     
===============================================
+ Hits             11649    11659      +10     
- Misses             849      850       +1     
  Partials             1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/S and removed size/L labels Jan 14, 2025
@JillieBeanSim JillieBeanSim marked this pull request as ready for review January 21, 2025 13:22
Copy link

📅 Suggested merge-by date: 2/4/2025

anaxceron
anaxceron previously approved these changes Jan 21, 2025
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 21, 2025
@JillieBeanSim JillieBeanSim changed the base branch from main to release/3.1 January 21, 2025 21:50
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 21, 2025
anaxceron
anaxceron previously approved these changes Jan 22, 2025
Copy link
Member

@phaumer phaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #3408

This change causes a big regression as it prohibits parallel downloads, which is required by extenders for scalability.

…st (#3409)

* fix: call Mutex.waitForUnlock instead of locking profile before request

Signed-off-by: Trae Yelovich <[email protected]>

* fix: AuthHandler.waitForUnlock

Signed-off-by: Trae Yelovich <[email protected]>

* tests: AuthHandler.waitForUnlock

Signed-off-by: Trae Yelovich <[email protected]>

* fix: add true opt-in support for profile locks w/ extender types

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>
* fix: use path.basename and helper fn to extract DS name

Signed-off-by: Trae Yelovich <[email protected]>

* test: add unit test to verify proper DS name

Signed-off-by: Trae Yelovich <[email protected]>

* chore: update changelog

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

I haven't seen any issues that haven't been identified in the 3.1.0 release branch 🙏
Thank you all for addressing all of the critical items found! 🙏

@traeok traeok merged commit 0efa5bb into release/3.1 Jan 28, 2025
22 checks passed
@traeok traeok deleted the prepare-3.1.0 branch January 28, 2025 16:20
Copy link

Release failed for the release/3.1 branch. 😢

Error: Protected branch release/3.1 does not allow minor version changes
    at Object.<anonymous> (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/core.js:38672:13)
    at Generator.next (<anonymous>)
    at /home/runner/work/_actions/zowe-actions/octorelease/v1/dist/core.js:69:61
    at new Promise (<anonymous>)
    at __async (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/core.js:53:10)
    at Object.verifyConditions (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/core.js:38657:10)
    at /home/runner/work/_actions/zowe-actions/octorelease/v1/dist/index.js:19082:30
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/index.js:40:24)

Check the workflow run for more error details.

Powered by Octorelease 🚀

Copy link

Release failed for the release/3.1 branch. 😢

Error: Protected branch release/3.1 does not allow minor version changes
    at Object.<anonymous> (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/core.js:38672:13)
    at Generator.next (<anonymous>)
    at /home/runner/work/_actions/zowe-actions/octorelease/v1/dist/core.js:69:61
    at new Promise (<anonymous>)
    at __async (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/core.js:53:10)
    at Object.verifyConditions (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/core.js:38657:10)
    at /home/runner/work/_actions/zowe-actions/octorelease/v1/dist/index.js:19082:30
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/index.js:40:24)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Check the workflow run for more error details.

Powered by Octorelease 🚀

zFernand0 added a commit that referenced this pull request Feb 3, 2025
* run l10n prepublish script

Signed-off-by: Trae Yelovich <[email protected]>

* fix: Avoid data-loss when creating new members (#3392) (#3397)

* fix: Avoid data-loss when creating new members (#3392)

* fix: Prompt users when creating members if the member exists

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* review: alternative way

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* test: add coverage for added memberFound logic

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: update changelog

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: cleanup commented code

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: simplify fix 😋

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* Update packages/zowe-explorer/CHANGELOG.md

Co-authored-by: Trae Yelovich <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>

---------

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>

* chore: move the changelog entry to the right location

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

---------

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>

* Fix internal error when extenders register new profile types (#3412) (#3416)

* Fix internal error when extenders register new profile types (#3412)

Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: downgrade ubuntu runners to ubuntu-22.04 (#3406)

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>

* Prepare 3.1.0 release (#3398)

* update lerna and remove un-needed changelog headers

Signed-off-by: Billie Simmons <[email protected]>

* add notes to readme's of VSC for older releases location with link

Signed-off-by: Billie Simmons <[email protected]>

* run package command

Signed-off-by: Billie Simmons <[email protected]>

* chore: downgrade ubuntu runners to ubuntu-22.04

Signed-off-by: Trae Yelovich <[email protected]>

* fix: call Mutex.waitForUnlock instead of locking profile before request (#3409)

* fix: call Mutex.waitForUnlock instead of locking profile before request

Signed-off-by: Trae Yelovich <[email protected]>

* fix: AuthHandler.waitForUnlock

Signed-off-by: Trae Yelovich <[email protected]>

* tests: AuthHandler.waitForUnlock

Signed-off-by: Trae Yelovich <[email protected]>

* fix: add true opt-in support for profile locks w/ extender types

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>

* fix(ds): Pass correct DS name in `stat` when doing remote lookup (#3407)

* fix: use path.basename and helper fn to extract DS name

Signed-off-by: Trae Yelovich <[email protected]>

* test: add unit test to verify proper DS name

Signed-off-by: Trae Yelovich <[email protected]>

* chore: update changelog

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>

---------

Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Co-authored-by: Fernando Rijo Cedeno <[email protected]>

* fix: update release config to allow minor release (#3419)

Signed-off-by: Trae Yelovich <[email protected]>

* Bump version to 3.1.0 [ci skip]

Signed-off-by: zowe-robot <[email protected]>

* Bump version to 3.2.0-SNAPSHOT [ci skip]

Signed-off-by: zowe-robot <[email protected]>

* update CHANGELOGS

Signed-off-by: Billie Simmons <[email protected]>

* chore: move recently merged PR into the tbd release section

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

Third-Party DCO Remediation Commit for Billie Simmons <[email protected]>

On behalf of Billie Simmons <[email protected]>, I, Fernando Rijo Cedeno <[email protected]>, hereby add my Signed-off-by to this commit: 0efa5bb

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* fix: correct expected value in createZoweSchema test

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: zowe-robot <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
Co-authored-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Co-authored-by: zowe-robot <[email protected]>
zFernand0 added a commit that referenced this pull request Feb 18, 2025
* run l10n prepublish script

Signed-off-by: Trae Yelovich <[email protected]>

* fix: Avoid data-loss when creating new members (#3392) (#3397)

* fix: Avoid data-loss when creating new members (#3392)

* fix: Prompt users when creating members if the member exists

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* review: alternative way

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* test: add coverage for added memberFound logic

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: update changelog

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: cleanup commented code

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: simplify fix 😋

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* Update packages/zowe-explorer/CHANGELOG.md

Co-authored-by: Trae Yelovich <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>

---------

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>

* chore: move the changelog entry to the right location

Signed-off-by: Fernando Rijo Cedeno <[email protected]>

---------

Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>

* Fix internal error when extenders register new profile types (#3412) (#3416)

* Fix internal error when extenders register new profile types (#3412)

Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>

* chore: downgrade ubuntu runners to ubuntu-22.04 (#3406)

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>

* Prepare 3.1.0 release (#3398)

* update lerna and remove un-needed changelog headers

Signed-off-by: Billie Simmons <[email protected]>

* add notes to readme's of VSC for older releases location with link

Signed-off-by: Billie Simmons <[email protected]>

* run package command

Signed-off-by: Billie Simmons <[email protected]>

* chore: downgrade ubuntu runners to ubuntu-22.04

Signed-off-by: Trae Yelovich <[email protected]>

* fix: call Mutex.waitForUnlock instead of locking profile before request (#3409)

* fix: call Mutex.waitForUnlock instead of locking profile before request

Signed-off-by: Trae Yelovich <[email protected]>

* fix: AuthHandler.waitForUnlock

Signed-off-by: Trae Yelovich <[email protected]>

* tests: AuthHandler.waitForUnlock

Signed-off-by: Trae Yelovich <[email protected]>

* fix: add true opt-in support for profile locks w/ extender types

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>

* fix(ds): Pass correct DS name in `stat` when doing remote lookup (#3407)

* fix: use path.basename and helper fn to extract DS name

Signed-off-by: Trae Yelovich <[email protected]>

* test: add unit test to verify proper DS name

Signed-off-by: Trae Yelovich <[email protected]>

* chore: update changelog

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>

---------

Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Co-authored-by: Fernando Rijo Cedeno <[email protected]>

* fix: update release config to allow minor release (#3419)

Signed-off-by: Trae Yelovich <[email protected]>

* Bump version to 3.1.0 [ci skip]

Signed-off-by: zowe-robot <[email protected]>

* Bump version to 3.2.0-SNAPSHOT [ci skip]

Signed-off-by: zowe-robot <[email protected]>

* Port #3428 into `release/3.1` (prep for 3.1.1 release) (#3435)

* fix(error): Check if `session` is valid before calling proxy setup fn (#3428)

* fix: check for valid session before calling proxy setup fn

Signed-off-by: Trae Yelovich <[email protected]>

* tests: CommonApi.getSession, reuse fake profile in other test

Signed-off-by: Trae Yelovich <[email protected]>

* chore: update ZE changelog

Signed-off-by: Trae Yelovich <[email protected]>

* fix: correct expected value in createZoweSchema test

Signed-off-by: Trae Yelovich <[email protected]>

* lint: resolve lint error in test code

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>

* fix: correct expected value in createZoweSchema test

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>

* Port #3417 Delete Keybinding fix (#3437)

* fix: Pass TreeView selection when node is undefined (#3417)

* fix: pass TreeView selection when node is undefined

Signed-off-by: Richelle Craw <[email protected]>

* fix: move node processing to USSActions

Signed-off-by: Richelle Craw <[email protected]>

---------

Signed-off-by: Richelle Craw <[email protected]>

* run prepublish

Signed-off-by: Billie Simmons <[email protected]>

* fix: correct expected value in createZoweSchema test

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Richelle Craw <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: Richelle Craw <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>

* update lerna to 3.1.1 (#3436)

Signed-off-by: Billie Simmons <[email protected]>

* Bump version to 3.1.1 [ci skip]

Signed-off-by: zowe-robot <[email protected]>

* Bump version to 3.2.0-SNAPSHOT [ci skip]

Signed-off-by: zowe-robot <[email protected]>

* run package & pretty commands

Signed-off-by: Billie Simmons <[email protected]>

* fix lint

Signed-off-by: Billie Simmons <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: zowe-robot <[email protected]>
Signed-off-by: Richelle Craw <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
Co-authored-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Co-authored-by: zowe-robot <[email protected]>
Co-authored-by: Richelle Craw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update size/L
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

5 participants