Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zwe Init Refactor to JCL for v3.x/staging #4107

Open
wants to merge 315 commits into
base: v3.x/staging
Choose a base branch
from

Conversation

MarkAckert
Copy link
Member

Test PR so we can compare the changes in this PR against the existing feature/v3/jcl which is based on v2.x/staging.

When these changes look correct, we'll rebase the feature/v3/jcl branch.

Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
… that see it is missing. make clear start and end to jcl output

Signed-off-by: 1000TurquoisePogs <[email protected]>
…se temp file. add zosmf keyring info to example-zowe

Signed-off-by: 1000TurquoisePogs <[email protected]>
… and having wait for job wait properly

Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
…opy un-needed jcl. add jcl for init apfauth command. start to deduplicate boilerplate

Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
…reated. trim vsam and mvs files

Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
@Martin-Zeithaml
Copy link
Contributor

@Martin-Zeithaml do you think this is ready to merge into #3718? After merge, we can change the head on that PR to v3.x/staging

I thought this will be merged (some day) into v3.x/staging and the #3718 will be just deleted.
I am testing this and making changes here only. There are some new problems.

@MarkAckert
Copy link
Member Author

We should close out #3718 then to avoid confusion with this PR. I can update the title and description. cc @1000TurquoisePogs does that sound OK to you?

@MarkAckert MarkAckert added the CICD_Quiet Used by automation to disable cicd comments on PRs. label Jan 29, 2025
@MarkAckert
Copy link
Member Author

@Martin-Zeithaml do you think this is ready to merge into #3718? After merge, we can change the head on that PR to v3.x/staging

I thought this will be merged (some day) into v3.x/staging and the #3718 will be just deleted. I am testing this and making changes here only. There are some new problems.

I took a stab at problems 2 and 3, without a complete test suite pointed at it. I added a new message ZWEL0320E which may not help with overloaded or sprawling messages...

@Martin-Zeithaml
Copy link
Contributor

Apfauth

Help:

  • zowe.setup.dataset.authLoadlib is the user custom APF LOADLIB. This field is
    optional. If it's not defined, SZWEAUTH from zowe.setup.dataset.prefix data
    set will be APF authorized.
  • zowe.setup.dataset.authPluginLib is the user custom APF PLUGINLIB.
    You can install Zowe ZIS plugins into this load library.

zowe.setup.dataset.authLoadlib and zowe.setup.dataset.authPluginLib omitted in config and this is generated by ZWEGEN00:

//STDPARM DD *                                          
SH cd '/zowe/' &&                       
cd bin/utils &&                                         
export LOADLIB='CFG.ZOWE.SETUP.DATASET.AUTHLOADLIB' &&  
export LOADLOC=SMS &&                                   
export PLUGLIB='CFG.ZOWE.SETUP.DATASET.AUTHPLUGINLIB' &&
export PLUGLOC=SMS &&                                   
./opercmd.rex "SETPROG APF,ADD,DSN=$LOADLIB,$LOADLOC" &&
./opercmd.rex "SETPROG APF,ADD,DSN=$PLUGLIB,$PLUGLOC"   
//*                                                     

When trying zwe init apfauth -c ./zowe.yaml:

ERROR: Error ZWEL0157E: zowe.setup.dataset.authLoadlib is not defined in Zowe YAML configuration file.

Expectation:
If zowe.setup.dataset.authLoadlib and zowe.setup.dataset.authPluginLib omitted, the JCL will authorize only zowe.setup.dataset.prefix.SZWEAUTH.

@MarkAckert
Copy link
Member Author

I started on the Apfauth updates, testing in the other PR. More changes to come - the first commit isn't working yet.

@MarkAckert MarkAckert changed the title [TEST] Sync of feature/v3/jcl on v3.x/staging Zwe Init Refactor to JCL for v3.x/staging Feb 11, 2025
setup:
# MVS data set related configurations
dataset:
dataset:
authLoadlib: ${{ zowe.setup.dataset.prefix }}.SZWEAUTH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of my old test is failing. There is no zowe.setup.dataset.prefix defined in the main config, so this line will generate undefined.SZWEAUTH. Then zwe command fails on schema validation:

Validity Exceptions(s) with object at
  Validity Exceptions(s) with object at /zowe
    Validity Exceptions(s) with object at /zowe/setup
      Validity Exceptions(s) with object at /zowe/setup/dataset
        Validity Exceptions(s) with string at /zowe/setup/dataset/authLoadlib
          string pattern match fail s='undefined.SZWEAUTH', pat='^([A-Z\$\#\@]){1}([A-Z0-9\$\#\@\-]){0,7}(\.([A-Z\$\#\@]){1}([A-Z0-9\$\#\@\-]){0,7}){0,11}$', at /zowe/setup/dataset/authLoadlib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD_Quiet Used by automation to disable cicd comments on PRs.
Projects
Status: No status
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants