Integrate seastar-rs#1
Open
patjed41 wants to merge 3 commits into
Open
Conversation
This commit enables seastar-rs usage in Scylla. To check that seastar-rs works correctly, a simple Rust module, test_seastar_rs, is added. This module exposes to C++ the spawn_sleep function that uses seastar-rs, and this function is called in Scylla's main.
This commit makes exposing async function to C++ possible by ensuring that cxx-async can be used in Rust and C++ code. To check that cxx-async works correctly, test_seastar_rs is extended by an async function - sleep. This function is also called from Scylla's main.
Now the headers are copied from cxx-async crate into build/.../gen/rust folder by build.rs script in main package. In order to avoid version mismatches, we patch cx-async version, so that all sub-crates use the same one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes using seastar-rs in Scylla possible and verifies it by adding a simple Rust module
test_seastar_rs. This modules exposes two functions (one synchronous and one asynchronous) to C++, and these functions are called in Scylla'smain.