XXX Minor improvements

zshamrock · Mar 2, 2021 · 7914aeb · 7914aeb
1 parent 9da2a47
commit 7914aeb
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/main.go b/main.go
@@ -112,14 +112,21 @@ func syncSecurityGroupInboundRule(
 	if err != nil {
 		return err
 	}
+	descriptionId := buildDescriptionId(username, location)
 	for _, group := range groups {
+		revoked := false
 		for _, inbound := range group.IpPermissions {
+			if revoked {
+				break
+			}
 			for _, entry := range inbound.IpRanges {
-				if aws.StringValue(entry.Description) == fmt.Sprintf("%s-%s", username, location) {
+				if aws.StringValue(entry.Description) == descriptionId {
 					err := revokeSecurityGroupIngress(svc, groupName, port, aws.StringValue(entry.CidrIp), username, location)
 					if err != nil {
 						return err
 					}
+					revoked = true
+					break
 				}
 			}
 		}