Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about scale factor #9

Open
shiyuleixia opened this issue Dec 19, 2024 · 7 comments
Open

about scale factor #9

shiyuleixia opened this issue Dec 19, 2024 · 7 comments

Comments

@shiyuleixia
Copy link

Super-resolution settings

basesr:
sf: 1
chopping: # for latent diffusion
pch_size: 512
weight_type: Gaussian

I change the scale factor to 1,but it dosen't work:
image

@zsyOAOA
Copy link
Owner

zsyOAOA commented Dec 19, 2024

Currently, our model only supports x4 SR task.

@flynnamy
Copy link

How to modify this? @zsyOAOA

@sunzhe09
Copy link

+1

@zsyOAOA
Copy link
Owner

zsyOAOA commented Dec 23, 2024

@sunzhe09 @flynnamy I have stated that our model only supports the x4 super-resolution task recently.

@flynnamy
Copy link

How to modify this? I do not understand why the scale factor has been fixed? @zsyOAOA

@zsyOAOA
Copy link
Owner

zsyOAOA commented Dec 24, 2024

How to modify this? I do not understand why the scale factor has been fixed? @zsyOAOA

Our noise predictor is trained to predict the noise map in the latent space of VQGAN, which is downsampled 8x times spatially. Thus we have to adjust the number of downsampling operators according to the scale factor. E.g., for x4 SR task, the noise predictor contains two downsampling layers as shown in [config[(https://github.com/zsyOAOA/InvSR/blob/master/configs/sample-sd-turbo.yaml#L43) to match the resolution of latent space. Therefore, we can't directly modify the scale factor! @flynnamy

@ManuBN786
Copy link

Thant means even if I put sf:1 during training, I still cant generate 1X SR at prediction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants