More informative warning about not finding edges, node #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@mununki thank you, this is great! Any chance you could set up a minimal reproduction for when this happens too? Sounds like something that needs to be fixing, that warning shouldn't be printed all the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using the 3.0-rc version, I noticed that the compiler keeps throwing a
Could not find nodewarning in the console. With the lack of information, it's hard to tell what's causing the error, so I'd like to suggest showing the connection name in the warning.I wasn't able to build PPX with esy locally, so I couldn't really test it. This PR is a feature suggestion, so you can take a look and close it.