Relay 20 #27
Closed
Relay 20 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed By: robhogan Differential Revision: D65816542 fbshipit-source-id: cb445eb77790fb2632d3bc318c6eb59f097b1518
Reviewed By: SamChou19815 Differential Revision: D66278779 fbshipit-source-id: 01dec1dc844607afa8f650c5acdebc6d5d5739d2
Reviewed By: poteto Differential Revision: D66196469 fbshipit-source-id: 1cfd2194c5ffaee1fc226e203d91a4cb004a2664
Reviewed By: alexmckenley Differential Revision: D66315470 fbshipit-source-id: 16b8fca3412fc2fcea3be8dfd0c760d97c56d734
Reviewed By: captbaritone, jackpope Differential Revision: D66128437 fbshipit-source-id: ca02ffde4a04e2633bca7c4e82d8fda3aff62093
Reviewed By: captbaritone, jackpope, lynnshaoyu Differential Revision: D66303103 fbshipit-source-id: cee2c8aaebb742cf84188fe1673ed53bb84be104
…liant lists Reviewed By: itamark Differential Revision: D65852550 fbshipit-source-id: 46315f62a08f578885c174939840678f9da80ca6
Reviewed By: sammy-SC Differential Revision: D66347840 fbshipit-source-id: 8c0d154444c519c4f0fe86d5908e4a63a809fe9a
Reviewed By: SamChou19815 Differential Revision: D66379853 fbshipit-source-id: 3a7677c5a71ef74e509ed43be87e455aed0cbaa7
Reviewed By: pieterv Differential Revision: D66477998 fbshipit-source-id: f4d1dbe506d6c42751fade897637031f0a43aa29
Reviewed By: lynnshaoyu Differential Revision: D66198675 fbshipit-source-id: a2eae6cc91f7e8c32c07252dd1ba62463941366a
Reviewed By: zertosh Differential Revision: D66562325 fbshipit-source-id: 9b4b0dd517c180b1856ce0dc9be3eb84d686c2b7
Summary: Automated changes by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action Pull Request resolved: facebook#4856 Reviewed By: zertosh Differential Revision: D66568562 Pulled By: dtolnay fbshipit-source-id: a1a1a7a14e1024d7e7cd3c50ff34c8c8be509f68
Differential Revision: D66596818 fbshipit-source-id: 0598e5449cd0717725749f6af5936abfb18530d9
Reviewed By: tyao1 Differential Revision: D66556691 fbshipit-source-id: a058fe4aa6a9630fdb00793625748a27c57e2278
Reviewed By: poteto Differential Revision: D66506950 fbshipit-source-id: fe6d085f5e6237778076957ac88e093c1ce4fea8
…ffect Reviewed By: josephsavona Differential Revision: D66303102 fbshipit-source-id: 15bcda870096292c4296d4496b5e5f9702b0a937
…on a different concrete type Reviewed By: captbaritone Differential Revision: D66555487 fbshipit-source-id: 86e4cec2c2bca04398bcafbad54a59efff8e861e
Reviewed By: evanyeung Differential Revision: D66559151 fbshipit-source-id: 0821af6b0629a1824157cd81d5e073ea9a5d121d
Reviewed By: tyao1 Differential Revision: D66254685 fbshipit-source-id: 09cd7be52a7a81e22e40a4048b361cd1079da65b
Summary: This diff adds a prefix to the storage key of all read-time resolvers. The `getStorageKey` function is used to generate a key that is used to create a link from a parent to child record. This key is designed to be unique based off of the field name and variables. However, the record holding data for read-time and exec-time resolvers is different. With both read time and exec time resolvers in the same project, it is now possible to have the same field name and variables, but want two different pieces of data being stored on the parent object. By prefixing the read-time resolver storage key, they are now disambiguated. Reviewed By: captbaritone Differential Revision: D66045529 fbshipit-source-id: d5b0317e15e86fa73ad37627c8e495f655da7403
Reviewed By: tyao1 Differential Revision: D66795906 fbshipit-source-id: 111b906bd78c4d0ba93e4c29a06de3421824ff06
Reviewed By: amyreese Differential Revision: D66886610 fbshipit-source-id: 8276a7f6164efec189ca0b87e535543ed5bc3615
Reviewed By: jbrown215 Differential Revision: D66886492 fbshipit-source-id: 9441e21e0ec1c2f6fa08a9aecd241251bf7218d7
Reviewed By: tyao1 Differential Revision: D66859587 fbshipit-source-id: 0c2aa816a0154e1db3483ff2135c4e6522d8e8e2
…facebook#4850) Summary: When not using Watchman the Relay Compiler will iterate over all files under `root_dir`, which can possibly include the entire repository. This is unnecessary work and might slow down large repositories. The watchman implementation only listens to files under the roots defined by the config, but this is not implemented for the directory walking implementation in `WalkDirFileSource`. This change moves the `get_all_roots()` functionality from `WatchmanFileSource` to `Config` and shares it with `WalkDirFileSource` to make it only iterate over the folders configured as targets in Relay. This fixes facebook#4849 Pull Request resolved: facebook#4850 Reviewed By: tyao1 Differential Revision: D66390485 Pulled By: captbaritone fbshipit-source-id: cdd6daa4368419dfcc012e50f8be45440f02cdcf
Reviewed By: SamChou19815 Differential Revision: D66979174 fbshipit-source-id: d94e8c42edd225fe367aac75e55d2c1d054acc07
Reviewed By: gordyf Differential Revision: D66987887 fbshipit-source-id: f9c32ba35dbc360682839507bf69533bd549b2a7
Reviewed By: captbaritone Differential Revision: D66908277 fbshipit-source-id: b0e62242b2ab323d7332604a612177101e24edd2
…facebook#4846) Summary: This PR fixes two issues we've encountered. 1. ResolverContext isn't passed through the `resolverDataInjector`. This surfaces specifically when using nested resolvers. 2. When updates propagate through the RelayStoreSubscriptions the context value is lost due the RelayStoreSubscriptions instance not receiving the context correctly. I noticed two of the 3 paths in `resolverDataInjector` do not seem to be covered by tests. Pull Request resolved: facebook#4846 Reviewed By: tyao1 Differential Revision: D66390780 Pulled By: captbaritone fbshipit-source-id: 0599b1807170b898f598d90969a1801a26958e37
Reviewed By: RandomEngy Differential Revision: D71629548 fbshipit-source-id: d73ceedcf0dd0390403aa6f964559eaa14ff96a7
Reviewed By: lynnshaoyu Differential Revision: D71520508 fbshipit-source-id: 73acffca2569697bb8f5915e6d78c359d89e326b
Reviewed By: cyan33 Differential Revision: D71633069 fbshipit-source-id: 3e50e5d0939a6365b0a3a956f195dfa78972db73
Reviewed By: panagosg7 Differential Revision: D71631538 fbshipit-source-id: e92c3edcefd6fa4d378a40e8ec97d3eda36e5ce3
Reviewed By: tyao1 Differential Revision: D71421963 fbshipit-source-id: 6c0f72775ba792055ca66195d7a2691ee669493c
Reviewed By: lynnshaoyu Differential Revision: D71768370 fbshipit-source-id: 141c2508f1f8144eca6cb0f2bd140891a2ca134b
Reviewed By: panagosg7 Differential Revision: D71639725 fbshipit-source-id: e48bfaae7be391044482489f805baa3df23af481
Reviewed By: capickett Differential Revision: D71530323 fbshipit-source-id: 0d75e6a124a5212bd21cd0cb3c763a0b78ffbaa8
Reviewed By: lynnshaoyu Differential Revision: D71771843 fbshipit-source-id: 49017f7f2e6dc35510426ae9dbebe6819cfaff33
Summary: Automated changes by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action Pull Request resolved: facebook#4939 Reviewed By: captbaritone Differential Revision: D71827434 Pulled By: monicatang fbshipit-source-id: 942b4f5e95ce14969496f588e8f25f6e1691a50c
Reviewed By: jackpope Differential Revision: D71899583 fbshipit-source-id: 4eab91c3b4864c4fcaff51ca2f8a1bf09108829d
Reviewed By: jbrown215, SamChou19815, panagosg7 Differential Revision: D72061660 fbshipit-source-id: a6862fe0e1f62992b76145006b3f8bc3ad788258
Reviewed By: gkz Differential Revision: D72133412 fbshipit-source-id: f7719284db67537a2c652ea56d9f9050210da7d4
Reviewed By: robhogan Differential Revision: D71805075 fbshipit-source-id: 685194c12ac037f74cc4fd54eb0d777a74507727
…ce to 0.27.0 Differential Revision: D71805075 Original commit changeset: 685194c12ac0 Original Phabricator Diff: D71805075 fbshipit-source-id: b28f0f83ad8b4f4f6b5e62fdc9ff323af79c1d43
…adata Reviewed By: captbaritone Differential Revision: D71346432 fbshipit-source-id: 29bfb713161c28776a75c69ac62280cdcc176dfb
Reviewed By: tyao1 Differential Revision: D72071270 fbshipit-source-id: 040875a77966cf830a37f24ee9efb9b87e06012d
Reviewed By: panagosg7 Differential Revision: D72353682 fbshipit-source-id: 72a1551870bc5a0abb7709fac94d442ffa200d89
Reviewed By: SamChou19815 Differential Revision: D72406426 fbshipit-source-id: 8a72ed9b0a0752a6b97bd324525ffdf1123c6619
Reviewed By: tyao1 Differential Revision: D72075980 fbshipit-source-id: 8064eb47f83632c413a86db61453b6a391544e30
Reviewed By: panagosg7 Differential Revision: D72417828 fbshipit-source-id: daa35a4c70bfd5e91ed1592a21c96619f9ebdd22
Reviewed By: SamChou19815 Differential Revision: D72423266 fbshipit-source-id: e6832fb66ffe8c4c548bcbcb23da0788e86f7139
Reviewed By: captbaritone Differential Revision: D72359401 fbshipit-source-id: 41eb6faaa19e9a29dd218898a4e7f278621345aa
Reviewed By: janettec Differential Revision: D72392851 fbshipit-source-id: c5571e922064092f4ac99d0e2b6672454c60df17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.