Relay 20.1.1

.eslintrc.js

@@ -34,6 +34,7 @@ module.exports = {
     'array-bracket-spacing': 'off',
     'comma-dangle': 'off',
     'max-len': 'off',
+    'no-extra-parens': 'off',
     'space-before-function-paren': 'off',
     'ft-flow/object-type-delimiter': 'off',
     'babel/flow-object-type': 'off',
@@ -89,4 +90,50 @@ module.exports = {
     'relay-internal/no-mixed-import-and-require': 'error',
     'relay-internal/sort-imports': 'error',
   },
+  overrides: [
+    {
+      files: ['packages/relay-runtime/**/*.js', 'packages/react-relay/**/*.js'],
+      excludedFiles: [
+        '**/__tests__/**',
+
+        // The following files should eventually be migrated to not break this
+        // rule. Until then, we'll grandfather them in here.
+        // If anyone feels inspired, they can:
+        //
+        // 1. Remove a file from this list
+        // 2. Run `yarn lint`
+        // 3. Fix/supress all warnings
+        // 4. Open a PR
+        // 5. Profit?
+        'packages/react-relay/relay-hooks/readFragmentInternal.js',
+        'packages/react-relay/relay-hooks/useEntryPointLoader.js',
+        'packages/react-relay/relay-hooks/useFragmentInternal_CURRENT.js',
+        'packages/react-relay/relay-hooks/useFragmentInternal_EXPERIMENTAL.js',
+        'packages/react-relay/relay-hooks/useQueryLoader.js',
+        'packages/react-relay/relay-hooks/useQueryLoader_EXPERIMENTAL.js',
+        'packages/relay-runtime/handlers/connection/MutationHandlers.js',
+        'packages/relay-runtime/multi-actor-environment/MultiActorEnvironment.js',
+        'packages/relay-runtime/mutations/RelayDeclarativeMutationConfig.js',
+        'packages/relay-runtime/mutations/createUpdatableProxy.js',
+        'packages/relay-runtime/store/DataChecker.js',
+        'packages/relay-runtime/store/OperationExecutor.js',
+        'packages/relay-runtime/store/RelayErrorTrie.js',
+        'packages/relay-runtime/store/RelayExperimentalGraphResponseHandler.js',
+        'packages/relay-runtime/store/RelayExperimentalGraphResponseTransform.js',
+        'packages/relay-runtime/store/RelayModernStore.js',
+        'packages/relay-runtime/store/RelayOperationTracker.js',
+        'packages/relay-runtime/store/RelayRecordSource.js',
+        'packages/relay-runtime/store/RelayReferenceMarker.js',
+        'packages/relay-runtime/store/RelayResponseNormalizer.js',
+        'packages/relay-runtime/store/live-resolvers/LiveResolverCache.js',
+        'packages/relay-runtime/store/observeFragmentExperimental.js',
+        'packages/relay-runtime/util/RelayReplaySubject.js',
+        'packages/relay-runtime/util/getValueAtPath.js',
+        'packages/relay-runtime/util/handlePotentialSnapshotErrors.js',
+      ],
+      rules: {
+        'relay-internal/no-for-of-loops': 'error',
+      },
+    },
+  ],
 };

.flowconfig

@@ -5,14 +5,8 @@
 .*/node_modules/resolve/test/resolver/malformed_package_json/package.json
 
 [options]
-as_const=true
 component_syntax=true
 module.system=haste
-module.system.haste.use_name_reducers=true
-# get basename
-module.system.haste.name_reducers='^.*/\([a-zA-Z0-9$_.-]+\.js\(\.flow\)?\)$' -> '\1'
-# strip .js or .js.flow suffix
-module.system.haste.name_reducers='^\(.*\)\.js\(\.flow\)?$' -> '\1'
 
 module.system.haste.paths.excludes=.*/__tests__/.*
 module.system.haste.paths.excludes=.*/__mocks__/.*
@@ -21,10 +15,7 @@ module.system.haste.paths.includes=<PROJECT_ROOT>/node_modules/fbjs/lib/.*
 munge_underscores=true
 ; https://fburl.com/code/h2jnts20 - to match internval value
 
-suppress_type=$FlowIssue
 suppress_type=$FlowFixMe
-suppress_type=$FlowFixMeProps
-suppress_type=$FlowFixMeState
 suppress_type=$FlowExpectedError
 
 format.bracket_spacing=false
@@ -42,4 +33,4 @@ untyped-import
 untyped-type-import
 
 [version]
-^0.253.0
+^0.278.0

.github/CONTRIBUTING.md

@@ -72,6 +72,10 @@ following steps should work for all Relay packages:
 1. Because of symbolic links and how Node resolves dependencies, you will probably want to instruct Node to resolve
    preserve the links `yarn node --preserve-symlinks-main --preserve-symlinks ./node_modules/.bin/relay-compiler […]`.
 
+## VSCode
+
+This repository has configuration files in the `.vscode/` directory to make development in VSCode easier. This includes enumerating recommended exensions (Flow, Rust Analyzer, Prettier, etc.) and sensible default settings (enable auto formatting etc.) to use when developing in this repository as well as some defined [Tasks](https://code.visualstudio.com/docs/debugtest/tasks) to easily trigger common actions directly via the command pallet.
+
 ## License
 
 By contributing to Relay, you agree that your contributions will be licensed under its MIT license.

.github/workflows/ci.yml

@@ -15,8 +15,8 @@ jobs:
       run:
         working-directory: ./vscode-extension
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: 20.x
           cache: 'yarn'
@@ -36,8 +36,8 @@ jobs:
       matrix:
         node-version: [18.x, 20.x]
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           cache: 'yarn'
@@ -50,8 +50,8 @@ jobs:
     name: JS Lint
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: 20.x
           cache: 'yarn'
@@ -68,8 +68,8 @@ jobs:
     name: Flow Typecheck
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: 20.x
           cache: 'yarn'
@@ -92,10 +92,13 @@ jobs:
             os: windows-latest
     runs-on: ${{ matrix.target.os }}
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.76.0
+          # Should stay in sync with fbcode/buck2/rust-toolchain
+          # And other similar references in this file and
+          # docusaurus.yml
+          toolchain: nightly-2025-05-09
           override: true
       - name: "Run tests"
         run: cargo test --manifest-path=compiler/Cargo.toml --locked ${{ matrix.target.features && '--features' }} ${{ matrix.target.features }}
@@ -115,10 +118,13 @@ jobs:
           #   os: windows-latest
     runs-on: ${{ matrix.target.os }}
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.76.0
+          # Should stay in sync with fbcode/buck2/rust-toolchain
+         # And other similar references in this file and
+          # docusaurus.yml
+          toolchain: nightly-2025-05-09
           override: true
       - name: "Update fixture tests"
         run: ./scripts/update-fixtures.sh
@@ -133,11 +139,11 @@ jobs:
     name: Rust Lint
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: actions-rs/toolchain@v1
         with:
           # Should stay in sync with tools/third-party/rustfmt/.rustfmt-version
-          toolchain: nightly-2024-07-28
+          toolchain: nightly-2025-04-14
           override: true
           components: rustfmt
       - name: "rustfmt"
@@ -175,13 +181,16 @@ jobs:
             artifact-name: relay-bin-win-x64
     runs-on: ${{ matrix.target.os }}
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.76.0
+          # Should stay in sync with fbcode/buck2/rust-toolchain
+          # And other similar references in this file and
+          # docusaurus.yml
+          toolchain: nightly-2025-05-09
           override: true
           target: ${{ matrix.target.target }}
-      - uses: actions/setup-node@v2
+      - uses: actions/setup-node@v4
         if: github.event_name == 'push' && github.repository == 'facebook/relay' && github.ref == 'refs/heads/main'
         with:
           node-version: 20.x
@@ -221,8 +230,8 @@ jobs:
     if: github.event_name == 'push' && github.repository == 'facebook/relay'
     needs: [js-tests, js-lint, typecheck, build-tests, build-compiler]
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: 18.x
           registry-url: https://registry.npmjs.org/

.github/workflows/docusaurus.yml

@@ -21,7 +21,16 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.76.0
+          # Should stay in sync with fbcode/buck2/rust-toolchain
+          # And other similar references in this file and
+          # ci.yml
+          # toolchain: nightly-2025-05-09
+
+          # Bug in rust causes wasm-pack to fail. Bug is fixed in
+          # https://github.com/rust-lang/rust/pull/139498 so we're temporarily
+          # ahead here while we wait for that fix to land in the common
+          # toolchain version used at Meta.
+          toolchain: nightly-2025-05-12
           override: true
       - name: Install wasm-pack
         run: curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh

.github/workflows/update-cargo-lock.yml

@@ -21,7 +21,10 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.76.0
+          # Should stay in sync with fbcode/buck2/rust-toolchain
+          # And other similar references in this file and
+          # ci.yml
+          toolchain: nightly-2025-05-09
           override: true
       - name: cargo check
         run: cargo check --features vendored --manifest-path=compiler/Cargo.toml

.github/workflows/vscode.yml

@@ -10,10 +10,10 @@ jobs:
       run:
         working-directory: ./vscode-extension
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v2
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: 16.x
+          node-version: 20.x
           cache: 'yarn'
       - name: Install dependencies
         run: yarn install --frozen-lockfile --ignore-scripts

.prettier-plugins.fb.js

@@ -0,0 +1,14 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ */
+
+module.exports = [
+  require.resolve(
+    '../../../../../../../tools/third-party/prettier/node_modules/prettier-plugin-hermes-parser/index.mjs',
+  ),
+];

.prettierrc.js

@@ -0,0 +1,25 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ * @oncall relay
+ */
+
+let plugins = ['prettier-plugin-hermes-parser'];
+try {
+  plugins = require('./.prettier-plugins.fb.js');
+} catch {}
+
+module.exports = {
+  arrowParens: 'avoid',
+  bracketSameLine: true,
+  bracketSpacing: false,
+  requirePragma: true,
+  singleQuote: true,
+  trailingComma: 'all',
+  parser: 'hermes',
+  plugins,
+};

.vscode/tasks.json

@@ -0,0 +1,43 @@
+{
+    "version": "2.0.0",
+    "tasks": [
+        {
+            "label": "Run Rust Compiler Tests",
+            "type": "shell",
+            "command": "cargo test",
+            "options": {
+                "cwd": "${workspaceFolder}/compiler"
+            },
+            "problemMatcher": [
+                "$rustc"
+            ]
+        },
+        {
+            "label": "Run Rust Compiler Tests (Update Snapshots)",
+            "type": "shell",
+            "command": "cargo test",
+            "options": {
+                "cwd": "${workspaceFolder}/compiler", 
+                "env": {
+                    "UPDATE_SNAPSHOTS": "1"
+                }
+            },
+            "problemMatcher": [
+                "$rustc"
+            ]
+        },
+        {
+            "label": "Regenerate Rust Tests for Fixture Files",
+            "type": "shell",
+            "command": "./scripts/update-fixtures.sh",
+            "problemMatcher": [
+                "$rustc"
+            ]
+        },
+        {
+            "label": "Build Relay artifacts for runtime tests",
+            "type": "shell",
+            "command": "./scripts/compile-tests.sh"
+        }
+    ]
+}