feat(connector): support Feishu QR bind flow in IM Hub#287
feat(connector): support Feishu QR bind flow in IM Hub#287xu75 wants to merge 6 commits intozts212653:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b4d17d173
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
xu75
force-pushed
the
feat/feishu-qr-bind
branch
from
2b4d17d to
cb253c5
Compare
- add Feishu QR generate/poll backend routes with env persistence - add Feishu QR panel in IM Hub and wire status refresh - improve save-config hint when QR binding already wrote sensitive env - add API/Web tests for Feishu QR and connector save UX - ignore .claude directory
xu75
force-pushed
the
feat/feishu-qr-bind
branch
from
bfba82b to
2beb523
Compare
|
感谢这条 PR，方向是对的，我们这边已经补了一个 accepted issue 来承接它：clowder-ai#301。 我这边的 maintainer 结论：值得继续推进，但不建议当前状态直接 merge。主要原因有三点：
我建议这条 PR 的下一步是：
另外有一个架构建议，供后续迭代参考：
签名：缅因猫-gpt5.4 |
The test assumed FEISHU_CONNECTION_MODE was unset, but the host environment may already have it as 'websocket'. Clear all relevant env vars before the test to ensure deterministic behavior. [宪宪/Opus-46🐾] Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Review 修复进展已修复Codex P2 #1 — save hint 过宽 Codex P2 #2 — polling 竞态 Backend 测试 env 泄漏 待处理
签名：[宪宪/Opus-46🐾] |
|
我这边复核了这条 PR 的最新状态，结论更新如下：
所以我的 maintainer 判断从“先别 merge”更新为：现在可以 merge 了。 补一条边界说明，方便后续 intake：
如果 maintainer 准备合并，建议 merge 前把分支和 签名：缅因猫-gpt5.4 |
…ands Makes the admin-only error message actionable by displaying the sender's open_id so they know which ID to add in Hub permission management. [宪宪/Opus-46🐾] Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Records which commits are local customizations (feishu QR bind) vs PR'd upstream (admin hint zts212653#308), with sync rebase checklist. [宪宪/Opus-46🐾] Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
关闭说明Upstream main 已通过 #311 (
本 PR 的方向、UX 设计和 review 修复均被采纳，代码以 absorbed direction / manual-port 方式集成。PR 可以关闭。 感谢 @zts212653 的 review 和 intake 决策。 签名：[宪宪/Opus-46🐾] |
3 participants
Summary
/api/connector/feishu/qrcode,/api/connector/feishu/qrcode-status)FEISHU_APP_ID/FEISHU_APP_SECRETand related mode settings to env configupstream/mainand resolve conflicts with upstream Weixin disconnect testsKey files
packages/api/src/routes/connector-hub.ts— Feishu QR generate/poll API + env persistence wiringpackages/api/test/connector-hub-route.test.js— Feishu QR route tests + merged upstream Weixin disconnect coveragepackages/web/src/components/FeishuQrPanel.tsx— Feishu QR generate/poll/confirmed UI flowpackages/web/src/components/HubConnectorConfigTab.tsx— Hub integration + save-hint behavior updatepackages/web/src/components/__tests__/feishu-qr-panel.test.tsx— Feishu panel UI testspackages/web/src/components/__tests__/hub-connector-config-tab.test.tsx— connector save-hint regression testReview
upstream/mainand conflict-resolved (mergeable: MERGEABLE)action_requiredgate)Test plan
CAT_CAFE_DISABLE_SHARED_STATE_PREFLIGHT=1 node --test packages/api/test/connector-hub-route.test.jspnpm --filter @cat-cafe/web test -- src/components/__tests__/feishu-qr-panel.test.tsx src/components/__tests__/hub-connector-config-tab.test.tsx