-
Notifications
You must be signed in to change notification settings - Fork 180
feat(scheduler): once trigger + lifecycle notifications (#415) #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
44e6ab9
feat(scheduler): support one-shot scheduled tasks (`once` trigger) (#…
mindfn 33be9af
fix(scheduler): cancel past-due once tasks on hydrate instead of exec…
mindfn 73d660e
feat(scheduler): add lifecycle notifications for all task state trans…
mindfn 624e69e
fix(scheduler): only send resume notification after successful re-reg…
mindfn 8a17462
fix(scheduler): address cloud review P1/P2 findings (#415)
mindfn 53b25ae
feat(scheduler): add success notification with next fire time (#415)
mindfn d6054cc
fix: biome format for project-setup-card-ime test
mindfn 90b0adc
Merge branch 'main' into feat/415-once-trigger
mindfn 1cf3c58
fix(scheduler): only retire once tasks after actual execution (#415)
mindfn ecb1eba
fix(scheduler): retry governance-skipped once tasks + scope tracking …
mindfn ce474ce
fix(scheduler): check started flag before retrying governance-skipped…
mindfn 54fbaf1
Merge branch 'main' into feat/415-once-trigger
mindfn 1fe5210
fix(scheduler): use ledger-based retry detection + unregister guard (…
mindfn 36cbd0d
fix(scheduler): use server-authoritative catId for lifecycle notifica…
mindfn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
packages/api/src/infrastructure/scheduler/schedule-notify.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| /** | ||
| * #415 Phase 2: Task lifecycle notifications | ||
| * | ||
| * Fire-and-forget notifications to delivery threads for lifecycle events: | ||
| * registered, paused, resumed, deleted, failed, missed-window. | ||
| */ | ||
|
|
||
| import { getNextCronMs } from './cron-utils.js'; | ||
| import type { DynamicTaskDef } from './DynamicTaskStore.js'; | ||
| import type { DeliverOpts, TriggerSpec } from './types.js'; | ||
|
|
||
| type DeliverFn = (opts: DeliverOpts) => Promise<string>; | ||
|
|
||
| /** Compute epoch ms of next fire time for a trigger */ | ||
| export function computeNextFireTime(trigger: TriggerSpec): number | null { | ||
| if (trigger.type === 'once') return trigger.fireAt; | ||
| if (trigger.type === 'cron') return Date.now() + getNextCronMs(trigger.expression, trigger.timezone); | ||
| if (trigger.type === 'interval') return Date.now() + trigger.ms; | ||
mindfn marked this conversation as resolved.
Show resolved
Hide resolved
mindfn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return null; | ||
| } | ||
|
|
||
| function formatTime(epoch: number): string { | ||
| return new Date(epoch).toLocaleString('zh-CN', { timeZone: 'Asia/Shanghai', hour12: false }); | ||
| } | ||
|
|
||
| function resolveUserId(def: DynamicTaskDef): string { | ||
| return ((def.params as Record<string, unknown>).triggerUserId as string) ?? 'system'; | ||
| } | ||
|
|
||
| function label(def: DynamicTaskDef): string { | ||
| return def.display?.label ?? def.templateId; | ||
| } | ||
|
|
||
| function fire(deliver: DeliverFn | undefined, def: DynamicTaskDef, content: string): void { | ||
| if (!deliver || !def.deliveryThreadId) return; | ||
| deliver({ threadId: def.deliveryThreadId, content, catId: 'system', userId: resolveUserId(def) }).catch(() => {}); | ||
| } | ||
|
|
||
| export function notifyTaskRegistered(deliver: DeliverFn | undefined, def: DynamicTaskDef): void { | ||
| const nextFire = computeNextFireTime(def.trigger); | ||
| const timeStr = nextFire ? formatTime(nextFire) : '未知'; | ||
| const once = def.trigger.type === 'once' ? '(一次性,执行后自动退役)' : ''; | ||
| fire(deliver, def, `✅ 定时任务「${label(def)}」已创建,下次执行时间:${timeStr}${once}`); | ||
| } | ||
|
|
||
| export function notifyTaskPaused(deliver: DeliverFn | undefined, def: DynamicTaskDef): void { | ||
| fire(deliver, def, `⏸️ 定时任务「${label(def)}」已暂停`); | ||
| } | ||
|
|
||
| export function notifyTaskResumed(deliver: DeliverFn | undefined, def: DynamicTaskDef): void { | ||
| const nextFire = computeNextFireTime(def.trigger); | ||
| const timeStr = nextFire ? formatTime(nextFire) : '未知'; | ||
| fire(deliver, def, `▶️ 定时任务「${label(def)}」已恢复,下次执行时间:${timeStr}`); | ||
| } | ||
|
|
||
| export function notifyTaskDeleted(deliver: DeliverFn | undefined, def: DynamicTaskDef): void { | ||
| fire(deliver, def, `🗑️ 定时任务「${label(def)}」已删除`); | ||
| } | ||
|
|
||
| export function notifyTaskSucceeded(deliver: DeliverFn | undefined, def: DynamicTaskDef): void { | ||
| if (def.trigger.type === 'once') { | ||
| fire(deliver, def, `✅ 定时任务「${label(def)}」已执行完成,任务已自动结束`); | ||
| } else { | ||
| const nextFire = computeNextFireTime(def.trigger); | ||
| const timeStr = nextFire ? formatTime(nextFire) : '未知'; | ||
| fire(deliver, def, `✅ 定时任务「${label(def)}」本次执行完成,下次执行时间:${timeStr}`); | ||
| } | ||
| } | ||
|
|
||
| export function notifyTaskFailed( | ||
| deliver: DeliverFn | undefined, | ||
| def: DynamicTaskDef, | ||
| errorSummary: string | null, | ||
| ): void { | ||
| const reason = errorSummary ? `:${errorSummary.slice(0, 200)}` : ''; | ||
| fire(deliver, def, `❌ 定时任务「${label(def)}」执行失败${reason}`); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.