-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zulip-integrations: Update google oauth and reminders for google calendar integration. #850
base: main
Are you sure you want to change the base?
Conversation
2249012
to
af1090e
Compare
@timabbott could you please review this PR? |
@Niloth-p It would be great to get your review on this one. |
@Niloth-p any updates? |
@timabbott @Niloth-p anything pending in this pr? |
Hi, @theofficialvedantjoshi, apologies for the delay in getting back. Thank you for the PR! If you're interested in working more on this integration, it would be helpful if you could help improve the message being generated, by adding separate commit(s) on top of this PR. Here are some ways we can improve the message:
|
Hi @Niloth-p, thanks for the review. I am interested in working more on this integration. I'll set things up locally and add the features mentioned above. I am also interested in participating in GSoC 2025 with zulip. Will you be mentoring this time? Will contributions to this repository add value to my proposal? |
Glad to hear that. Contributions to this repo do count as much as any other Zulip repo. Though I anticipate being involved with any GSoC contributors working on Zulip integrations, and the set of integrations here in this repo could do with a lot of improvements, the priorities of GSoC contributions and project proposals is not my domain, the GSoC channel is a much better place to get info regarding that. |
Hello @theofficialvedantjoshi, it seems like you have referenced #847 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage. Please run An example of a correctly-formatted commit:
To learn how to write a great commit message, please refer to our guide. |
3626384
to
50a9579
Compare
Will be working on features related to |
Fixed reminder logic to respect Google Calendar's
|
The
oauth2client
library used in the google-calendar integration scripts has become deprecated. This PR updates the script to replaceoauth2client
with other libraries that Google is now using, specificallygoogle-auth-httplib2
andgoogle-auth-oauthlib
.Fixes: #847
How did you test this PR?
client_secret.json
file from a test Google Cloud application that uses the calendar API.google-credentials.json
in the home directory.Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: