Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream_settings: Fix jitter behavior of plus/checkmark. #30557

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sujalshah-bit
Copy link
Collaborator

@sujalshah-bit sujalshah-bit commented Jun 24, 2024

Previously, we show loading spinner in each streams rows. Now we show directly plus or checkmark icon instead of loading spinner.

CZO

Screenshots and screen captures:
Before:
stream2

After:

stream3

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@alya
Copy link
Contributor

alya commented Jun 24, 2024

@sujalshah-bit please ping your buddy for review.

@alya alya added the buddy review GSoC buddy review needed. label Jun 24, 2024
@adnan-td
Copy link
Collaborator

LGTM but I have noticed a related bug:

add_subscriber_button_bug

When clicking on the subscribe button, the add button becomes enabled (from disabled). This still feels like jitter as transition from disabled to enabled is visible.

Previously, we show loading spinner in each streams rows.
Now we show directly plus or checmark icon instead of loading spinner.
Previously when user subscribe to channel `Add` button gets active.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buddy review GSoC buddy review needed. size: L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants