Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to notification settings #30609

Closed

Conversation

SamarthKoli
Copy link
Collaborator

@SamarthKoli SamarthKoli commented Jun 27, 2024

Title: Add Help Links to Notification Settings Sections

Description:
This pull request adds help links to the "Topic notifications," "Desktop message notifications," "Mobile message notifications," and "Email message notifications" sections in the notification settings form. These links will direct users to the relevant help documentation pages, improving usability and user guidance.

Commit 1: Add Help Link to "Topic Notifications" Section

Added ../help_link_widget partial inside the

tag for the "Topic notifications" section.
Linked to the help page for topic notifications: /help/topic-notifications.

`


{{t "Topic notifications" }}
{{> ../help_link_widget link="/help/topic-notifications" }}


{{> settings_save_discard_widget section_name="topic-notifications-settings" show_only_indicator=(not for_realm_settings) }}


{{#tr}}
You will automatically follow topics that you have configured to both follow and unmute.
{{#*inline "z-follow"}}{{> @partial-block}}{{/inline}}
{{#*inline "z-unmute"}}{{> @partial-block}}{{/inline}}
{{/tr}}

`

Review Checklist:

  • [ Added help links to "Topic notifications," "Desktop message notifications," "Mobile message notifications," and "Email message notifications" sections.
    ]

  • [ Verified links direct to the correct help documentation pages]

  • [ Tested the changes locally to ensure the links appear and function correctly.]

@SamarthKoli SamarthKoli reopened this Jun 27, 2024
@SamarthKoli SamarthKoli deleted the Add-Links-to-notification-settings branch June 27, 2024 05:48
@SamarthKoli SamarthKoli restored the Add-Links-to-notification-settings branch June 27, 2024 05:48
@SamarthKoli SamarthKoli reopened this Jun 27, 2024
@alya
Copy link
Contributor

alya commented Jun 27, 2024

Thanks! Please go through our guide on submitting a pull request to learn how to present your proposed changes to Zulip, so that your work can be reviewed.

@alya
Copy link
Contributor

alya commented Jun 27, 2024

This issue may be solved in #30568?

@SamarthKoli SamarthKoli marked this pull request as draft June 27, 2024 07:29
@SamarthKoli SamarthKoli marked this pull request as ready for review June 27, 2024 07:31
@SamarthKoli SamarthKoli reopened this Jun 27, 2024
@timabbott
Copy link
Sponsor Member

This pull request seems to have 0 lines of changes.

@SamarthKoli please take some time to learn Git and GitHub, it'll be a better experience for both you and open-source projects you'd like to contribute to.

@timabbott timabbott closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants